ChiriVulpes / MagicTranslator

Turning scanlation into a magical experience ✨
4 stars 1 forks source link

Project settings's `raw` pattern should allow for picking different extension #131

Closed milleniumbug closed 4 years ago

milleniumbug commented 4 years ago

Currently the default is {volume}/{chapter}/raw/{page}.png, but changing to {volume}/{chapter}/raw/{page}.jpg doesn't do anything because there seems to be a hardcoded assumption to use .pngs in https://github.com/Yuudaari/MagicTranslator/blob/a629ce8890e6203947f120af52b5c86c9e7f1790/script/window/data/Projects.ts#L216 and a few other places too.

Why .jpgs? Because the raw is .jpg and converting it to .png won't help with anything except taking more space on the hard drive.

I spent around an 1h untangling that today, but with no luck. Posting an issue so I won't forget (or you'll deal with it, but I may get to it quicker)