Use case: translated pages being scaled from the original page size

ChiriVulpes / MagicTranslator

Turning scanlation into a magical experience ✨

4 stars 1 forks source link

Use case: translated pages being scaled from the original page size #144

Closed milleniumbug closed 2 years ago

milleniumbug commented 2 years ago

Sometimes we're upscaling and denoising the pages from a lower resolution raw to, among other things, make sure the fonts look crisp.

The rendered captures are positioned wrong as a result in "Translated" mode.

ChiriVulpes commented 2 years ago

~~Can you add a way to repro this to the magical trans repo?~~ Nvm I can repro

milleniumbug commented 2 years ago

No repro in Bro Girl and Magical Trans repos, though this use case shows up in GhoStop (sent you an invite) which has 848x1200 sized raws, which are upscaled in psd files directory, and as a result, in translated directory.

milleniumbug commented 2 years ago

This implementation has a problem in that

v2 captures have catastrophic failure in older versions than the current will assume it's v1 capture and draw a <1px-sized square (in theory not a problem because it's beta, in practice it is because I'd have to give Priestess of Athe a newer version of it, and I still don't know how to build it in a way that works)
the existing projects have to be migrated, which means me writing extra code for this.

Instead, I suggest:

Adding the new optional fields to the Captures extends Serializable class that indicate the raw size (e.g. 1114x1600)
If this field is present, scale the captures appropriately (get the size of the "translated" pic, let's say 2228x3200, get the "raw" size 1114x1600, get multipliers (here: 2x2), scale & transform captures according to the multipiers)

ChiriVulpes commented 2 years ago

She'll need an updated build no matter what in order to make all captures appear in the right place in all situations. I dunno why any of that is necessary

ChiriVulpes commented 2 years ago

Also the whole reason for me separating v1 and v2 captures was so that old captures continued to work like they do now and future ones work better. Figured that was better than me breaking all old captures. I don't really want to put in the development time of making v1 captures work the same as v2, it seems like a waste of time to me. If it's important to you though you're welcome to fix it

milleniumbug commented 2 years ago

I personally don't see it as "breaking the old captures" as "translated images being scaled wrt raws" was an unsupported scenario in the first place, and from my perspective "breaking" these projects actually fixes them.

I'm certainly gonna give it a shot because I can base the changes on your own code.

ChiriVulpes commented 2 years ago

No I mean like what I was initially going to do is just have my code assume that all capture positions were percentage based which would've broken old captures