search

ChiriVulpes / scryfall-sdk

A Node.js SDK for https://scryfall.com/docs/api, written in TypeScript.
MIT License
99 stars 16 forks source link

Implement /cards/collection endpoint #13

Closed Joel-Mercier closed 5 years ago

Joel-Mercier commented 5 years ago

Hi, first off great work ! Your sdk has been really helpful to me ! I was just wondering and I hope I didn't miss it but the /cards/collection endpoint (https://scryfall.com/docs/api/cards/collection) doesn't seem to be implemented. Any plans to support this ? I can get by without it but it would be awesome

ChiriVulpes commented 5 years ago

This wasn't yet a thing last time I did dev on the project. I'll make time to implement this sometime soon, thanks for the ping!

Joel-Mercier commented 5 years ago

Hi any news on this ? This endpoint would be very useful for card collections (like decks)

ChiriVulpes commented 5 years ago

It's implemented as of v1.4.0

Sorry about that, I should have made some time before now but I just didn't. It didn't even take long to implement, maybe like 3 hours. I really should have done that sooner 😓

Joel-Mercier commented 5 years ago

Awesome ! will test