search

ChiriVulpes / scryfall-sdk

A Node.js SDK for https://scryfall.com/docs/api, written in TypeScript.
MIT License
99 stars 16 forks source link

added missing fields to Cards.ts #42

Closed sili3011 closed 2 years ago

sili3011 commented 2 years ago

reference: https://scryfall.com/docs/api/cards

ChiriVulpes commented 2 years ago

Thanks for this! I will note that I’m in the middle of a fairly substantial usability update and don't bother with branches in this project, so it's going to take a little while for this to be merged and published on npm. Hope that's alright!

multimeric commented 2 years ago

Any update on this? I note that there are also some other changes needed, like allowing card.layout to include modal_dfc.

sili3011 commented 2 years ago

Any update on this? I note that there are also some other changes needed, like allowing card.layout to include modal_dfc.

I havent heard from them since, but I can look into it later, push changes and you can patch your package with this branches code

multimeric commented 2 years ago

That would be great, thanks!

sili3011 commented 2 years ago

Done! Let me know if you notice something else missing.

ChiriVulpes commented 2 years ago

I'm gonna try to either finish everything and get a new sdk major version out today, or if I don't manage to finish it I'll just release a version under the beta tag. Thanks for the PR, sorry about the really long wait