search

ChiriVulpes / soulus

A Minecraft mod. You must sift through the ashes of the dead to restore life to the world.
https://soulus.info
Other
3 stars 3 forks source link

Localisation name for custom mobs #23

Closed Thyriel closed 6 years ago

Thyriel commented 6 years ago

Only a minor issue: When adding totally new entry to essences.json there seems to be no way to specify a localisation name so essence / book is then shown ingame as item.soulus:essence/soulbook.mobID.name

Spawning / obtaining these essences works great, even the spawner has the correct mob rendering in it but would be great if i could specify a name in essences.json to be used.

ChiriVulpes commented 6 years ago

I didn't think I could actually do this, which is why it works the way it does now, but I'll give this another shot. Originally I would recommend adding extra language to your pack, but if I can figure it out that won't be necessary anymore.

ChiriVulpes commented 6 years ago

Added automatic name support for essences, soulbooks, and summoners. Added config support for manually naming essences.

ChiriVulpes commented 6 years ago

Fixed as of v2.5.0

Thyriel commented 6 years ago

Thanks :) Could you give me a config example of how to use this ? "Added config support for manually naming essence types."

ChiriVulpes commented 6 years ago

It should just work for all mobs automatically (it uses the display name of the mob). If a mob doesn't work, can you let me know which it is? I'll try and fix it. Until then, as soon as you launch the game it should actually fix the current essences.json, with a new name property in each entry set to null. Just change that to whatever you want the name to be, it will name the items of that type <name> Essence, Soulbook of <name>, and Summoner of <name>

Thyriel commented 6 years ago

Works like a charm :) All are automatically named now correctly based on the mobs name and manually renaming them works too. Interestingly the newly generated essences.json also reordered most "spawns" and "loot" sections for some reason but that shouldn't make any difference

ChiriVulpes commented 6 years ago

Yea, the order of a JSON object is never guaranteed. Basically, what happens there is the original data is imported into the game, it uses the default values for anything missing, and then it creates a new JSON file from it. If the two files don't have the same data (in this case, they don't, since name was added), and the file text is different (obviously), the original file is replaced with the new one. Therefore, if your file is correct and has a different order, it will still keep it (since the content of the JSON objects are the same). If it always replaced the file if just the text was different it would probably replace all the files with a new one every time it loaded, as all the orders of the JSON objects would be randomised.

ChiriVulpes commented 6 years ago

I'm not sure if you know (I don't remember if I mentioned it in the readme anywhere) but you can actually use /soulus reload to reload all the configs while in game. When adding or removing stuff to soulus such as essences this will likely be your best friend.