search

ChiriVulpes / soulus

A Minecraft mod. You must sift through the ashes of the dead to restore life to the world.
https://soulus.info
Other
3 stars 3 forks source link

Added Ice Fossil variants, switched Fossil Blocks to texture overlay system #52

Closed YaibaToKen closed 5 years ago

ChiriVulpes commented 6 years ago

Please .gitignore your classes/production directory

YaibaToKen commented 6 years ago

ups, my bad, I think that's all of them

ChiriVulpes commented 5 years ago

I don't think I'm going to be able to merge this.

  1. I don't see a way of making the ice fossils not look dumb. I don't think there's a way to get them to cull their faces when they're adjacent to another type of ice block, so all of their veins will just always have borders and look bad as a result, even if I stick little bone box models inside of them (which was my plan).
  2. Resourcepacks already have the ability to change block models. If a resourcepack wanted to, they could make their fossils use layers. I want finer control in my fossil textures, hence not using layers in my own models.
  3. This PR is just hard to merge in general because there are a lot of unrelated changes. It would have been easier to deal with if they were multiple PRs, each with a more specific goal in mind. IE, one for adding layers to the block model by default, one for adding ice fossils, and one for reorganising the fossils block files. (The only one I would have merged is the third one, probably — I think I'll reorganise it on my end tho)

Since the ice fossils are rejected due to inability to make the appearance better, I'll explain again how you can add ice fossils to a modpack without Soulus having them.

  1. Add a block via content tweaker.
  2. Set the drops of your block to bone chunks. You can use Content Tweaker for this as well, or you can use another drop handler mod like Dropt
  3. Edit the fossil configs (config/soulus/world/veins/veins.json) to add veins for your fossil.

That's literally all you should need in order to add custom fossil blocks in general.