Make TOP work on servers

ChiriVulpes / soulus

A Minecraft mod. You must sift through the ashes of the dead to restore life to the world.

https://soulus.info

Other

3 stars 3 forks source link

Make TOP work on servers #54

Closed pupnewfster closed 5 years ago

pupnewfster commented 5 years ago

I decided to leave method names alone to minimize the diff to make it easier to read through the changes.

What changed:

Removed ClientSide Only annotations
Changed usages of I18n to using TextComponentTranslation so that the server can tell the client to translate it once it gets it.
Import Order as I had optimize Imports on to remove unused imports

Fixes #53

ChiriVulpes commented 5 years ago

Everything looks good, thanks a bunch!

ChiriVulpes commented 5 years ago

How would you like to be credited in the next version of Soulus? As "pupnewfster" or something else?

ChiriVulpes commented 5 years ago

Fixed TOP not working on servers. Thanks pupnewfster!

pupnewfster commented 5 years ago

If you want that is fine, though not really necessary as it basically was just removing SideOnly annotations and switching it from I18n to something that exists on servers so that it doesn't crash when being attempted to use.