search

ChiriVulpes / soulus

A Minecraft mod. You must sift through the ashes of the dead to restore life to the world.
https://soulus.info
Other
3 stars 3 forks source link

Fix murky orb and full soulbook advancements #76

Closed codewarrior0 closed 5 years ago

codewarrior0 commented 5 years ago

Seems the maximum essence contained in these items had changed since the advancements were created?

codewarrior0 commented 5 years ago

Actually, it looks like the maximum essence in these items is configurable? Might need to rework these advancements instead.

ChiriVulpes commented 5 years ago

https://github.com/Yuudaari/soulus/blob/master/src/main/java/yuudaari/soulus/common/config/item/ConfigOrbMurky.java#L16

https://github.com/Yuudaari/soulus/blob/master/src/main/java/yuudaari/soulus/common/config/essence/ConfigEssence.java#L18

128 and 16 are the correct numbers if you're using the default configs, but the advancements don't currently change if the configured amts change. I think you can tweak advancements w/ a resource replacement mod or sth tho, right?

codewarrior0 commented 5 years ago

Right, sorry. I'll report this to the modpack author instead.