1.20 version of #204 while making breaking changes as there hasn't been a release of 1.20 yet.
Changes:
Fixes crash in prod due to shadowed field not being reobf'd
Ensure that ambient occlusion is not stripped when unbaking and rebaking quads (#202)
Fixed always (except for leaves) including solid as a render type for baked CTM models which was causing the sugar cane CTM test resources to render with black boxes as opposed to respecting cutout
Fixed using default render types instead of model based types for rendering the item variants of baked CTM models which was causing translucent based blocks to render incorrectly as can be seen by the pictures of the item variants in #202
Respect model render types for fallback in baked CTM model rather than using the broken canRenderInLayerFallback method
Switched to using the helper QuadBakingVertexConsumer.Buffered rather than effectively reimplementing it
Removed a lot of unused and deprecated bits of CTMPackReloadListener and removed corresponding no longer necessary ATs
Questions/comments:
In ModelCTM the formatting displays incorrectly for one of the changes as that section of code uses a mix of tabs and spaces so I am not quite sure what formatting it is supposed to have so if you have any input let me know and I can fix it.
I am not fully positive about the desired rendering of items for CTM so I am basically having it do what it was which is defaulting to how the base block version would render (which seems to be working fine), but figured I should ask if this should use the new getExtraLayers method directly or not
1.20 version of #204 while making breaking changes as there hasn't been a release of 1.20 yet.
Changes:
canRenderInLayerFallback
methodQuadBakingVertexConsumer.Buffered
rather than effectively reimplementing itCTMPackReloadListener
and removed corresponding no longer necessary ATsQuestions/comments:
ModelCTM
the formatting displays incorrectly for one of the changes as that section of code uses a mix of tabs and spaces so I am not quite sure what formatting it is supposed to have so if you have any input let me know and I can fix it.getExtraLayers
method directly or not