ChiselsAndBits / Chisels-and-Bits

A Minecraft mod about chiseling and designing custom blocks in game.
https://algorithmx2.github.io/Chisels-and-Bits/
MIT License
222 stars 81 forks source link

blocks disappearing (not visible) #118

Closed Eaglexxv closed 8 years ago

Eaglexxv commented 8 years ago

AlgorithmX2 Thank you for your hard work and time great Mods. I'm using C&B 11.9 beta for this this is not happening in 11.7 as far as I can tell so far. I'm using both Chisels&bits and Flat color blocks I have made a few new blocks using the mods together like a lantern also a glowing stone brick for pathways. But now I'm having a problem with the chiseled blocks visually disappearing but still "physically" there . I'm not sure how to show this to you but ill try to do some screen shots. I seems it might have something to do with the glowing blocks. This is more for your info then a complaint. If I can do anything to help you let me know. 1st pic no made glow block everything is fine 2nd is with a made glow block in a different chuck everthing is fine 3rd is with made glow block in same chuck as the house and now any C&B block is visually gone. It still acts like a block is there including the glow. Thanks Eaglexxv 2016-08-06_12 42 32 2016-08-06_12 42 42 2016-08-06_12 43 
[ ] 50

weeryan17 commented 8 years ago

I'm going to work on the chunk related issue some more by compiling a list of all the mod blocks within a "bad" chunk. If you manage to find the exact problem before i finish the list then yay! Hopefully this list will provide some info to help you.

AlgorithmX2 commented 8 years ago

I was able to reproduce the render issue with just journeymap and C&B.

weeryan17 commented 8 years ago

@AlgorithmX2 hmm it must be multiple then because i don't have journey map. slow progress is slow

AlgorithmX2 commented 8 years ago

Its quite possible, i'm not sure what state is causing the issue yet, but once I track that down it will probably resolve for all of the mods using it.

weeryan17 commented 8 years ago

Currently all of the chunks that were "bad" have contained tinkers construct stuff their so far hasn't been any other overlap in all the chunks affected. so a state in tinkers construct as well?

AlgorithmX2 commented 8 years ago

Hard to say for certain, since Journeymap for instance has no blocks, but it renders gui elements.

Once I work out whats going on with Journeymap we'll re-test to make sure its fixed across the board.

Eaglexxv commented 8 years ago

I did have tinkers construct also

AlgorithmX2 commented 8 years ago

So, I'm pretty sure I just chased my tail for like an hour, and I have no idea why I couldn't reproduce this without a second mod, since when I finally tracked down the issue it was actually a rather simple issue, one that had nothing to do with OpenGL or states, nor any other mod...

Without further ado, hopefully this build fixes the issue, please confirm, https://dvs1.progwml6.com/jenkins/job/Chisels-and-Bits/10/artifact/build/libs/chiselsandbits-11.0.10.jar

Eaglexxv commented 8 years ago

BY JOLLY I THINK YOU HAVE IT 8)!!!!!!!!!!
Great job looking great been messing around with it for a few hours with everything is stable. So I confirm that on my side it is fixed. Hope I was more of a help then a pain in the ass ( but I do like being a pain in the ass)

if I asked what was the problem It seemed so wierd?

If I can help you in the future let me know Eaglexxv

weeryan17 commented 8 years ago

I just woke up so i haven't gotten to testing yet but by the sounds of it everything is fine (besides the server not sending chisel and bits blocks sometimes witch I'll probably make a new issue for).

weeryan17 commented 8 years ago

Looks like it's fixed. ether that or I'm getting really unlucky making it happen again but i think it's fixed

AlgorithmX2 commented 8 years ago

@Eaglexxv the issue was that when I was adding VBO support I had to changes few things, one of those things ended up not getting a proper implementation.

So instead of a list with the block in it, it was just an empty list.


Thanks for the help @Eaglexxv, @weeryan17 I'm glad we finally got this fixed, I'll be releasing a new official build later today when I close this issue.

Dushess commented 7 years ago

Hello, i have the same bug on 1.9, mod has been updated and after 10.19 (and 11.10) problem is solved. But i building a project using mods, that now released only on 1.9.4 max (or even 1.9). It possible to fix problem for version 9.21? Thanks. Add: more info about problem manifestation here - http://www.minecraftforum.net/forums/support/modded-client-support/2752918-wrong-chunks-reloading-ingame-chisels-bits-mod

AlgorithmX2 commented 7 years ago

@Dushess The bug in for this issue was resolved in https://minecraft.curseforge.com/projects/chisels-bits/files/2322263 which is a 1.9.4 build.

However the issue linked above ( https://github.com/AlgorithmX2/Chisels-and-Bits/issues/123 ) was another issue where certain blocks would fail to render, however the fix for that issue requires 1.10.

Its likely that if your already using v10.19 that your issues is actually #123 which requires 1.10 I can't back port that fix, since it requires changes not made in vanilla until 1.10.

Dushess commented 7 years ago

Now i use MC1.9 but i using client only mode. (that's not server, my project specified for client side)

Dushess commented 7 years ago

I will try 1.9.4 version with other mods on that, and will notify if i'll catch that problem.

weeryan17 commented 7 years ago

@Dushess do you have a problem where a whole chunk isn't rendering or where only a few blocks are not rendering. if it's a hole chunk the it's probably this just not quite solved all the way. if it's individual blocks the your problem is covered in issue #123 with requires 1.10 to fix.

AlgorithmX2 commented 7 years ago

@weeryan17 based on the description ( http://www.minecraftforum.net/forums/support/modded-client-support/2752918-wrong-chunks-reloading-ingame-chisels-bits-mod ) the bug appears to affect 1-2 blocks when a chunk loads.

Which sounds quite like the other issue, and not this one.

Dushess commented 7 years ago

Upd Info: Installed same mod set for 1.9.4 - at this moment all fine (knoks the table x3), no chiseled block rendering glitches, no

[Client thread/FATAL]: Error executing task java.util.concurrent.ExecutionException: java.lang.StackOverflowError at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_40] at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_40] at net.minecraft.util.Util.func_181617_a(SourceFile:46) [g.class:?] at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1041) [bcf.class:?] at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:366) [bcf.class:?] at net.minecraft.client.main.Main.main(SourceFile:124) [Main.class:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_40] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_40] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_40] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_40] at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] Caused by: java.lang.StackOverflowError at net.minecraft.world.World.func_175624_G(World.java:3147) ~[aht.class:?] at net.minecraft.world.chunk.Chunk.func_186032_a(Chunk.java:466) ~[ase.class:?] at net.minecraft.world.chunk.Chunk.func_177435_g(Chunk.java:461) ~[ase.class:?] at net.minecraft.world.chunk.Chunk.func_177422_i(Chunk.java:756) ~[ase.class:?] at net.minecraft.world.chunk.Chunk.func_177424_a(Chunk.java:775) ~[ase.class:?] at net.minecraft.world.World.func_175625_s(World.java:2380) ~[aht.class:?] at mod.chiselsandbits.chiseledblock.BlockChiseled.getTileEntity(BlockChiseled.java:286) ~[BlockChiseled.class:?] at mod.chiselsandbits.chiseledblock.BlockChiseled.isNormalCube(BlockChiseled.java:165) ~[BlockChiseled.class:?] at net.minecraft.world.World.func_175666_e(World.java:3713) ~[aht.class:?] at net.minecraft.world.World.func_175690_a(World.java:2430) ~[aht.class:?] at net.minecraft.world.chunk.Chunk.func_177424_a(Chunk.java:776) ~[ase.class:?] at net.minecraft.world.World.func_175625_s(World.java:2380) ~[aht.class:?] ...

in log when player in this area, continue checking and hope that's stable condition.