search

ChiselsAndBits / Chisels-and-Bits

A Minecraft mod about chiseling and designing custom blocks in game.
https://algorithmx2.github.io/Chisels-and-Bits/
MIT License
222 stars 81 forks source link

fix world won't be loaded after placing ChiseledBlock #1222

Closed singlerr closed 5 months ago

singlerr commented 5 months ago

As described in https://github.com/ChiselsAndBits/Chisels-and-Bits/issues/1216, IBlockEntityPositionManager.getInstance().add(this) causes deadlock, which consequently getting stuck in 100% of world load.

It is commonly known that it only occurs on fabric, so we need to use mixin to simply disabling IBlockEntityPositionManager#add call and manually adding block entity to IFabricBlockEntityPositionHolder.

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

marchermans commented 5 months ago

Please fix this in in Scena. It is our own library, no need to mixin stuff