search

ChiselsAndBits / Chisels-and-Bits

A Minecraft mod about chiseling and designing custom blocks in game.
https://algorithmx2.github.io/Chisels-and-Bits/
MIT License
218 stars 80 forks source link

Chiselling any blocks that produce light deactivates them, making them stop producing light. #286

Closed SerenDark closed 7 years ago

SerenDark commented 7 years ago

A user on my server is having an issue. "Anything that produces light does not work with the mod. If you chisel glowstone/lamps, it makes them inactive. Is there a way to fix this?"

AlgorithmX2 commented 7 years ago

Glowstone lamps require redstone signal? And C&B doesn't mimic such behaviors, thus a lamp would deactivate when chiseled.

Did I understand your report correctly?

eriniki commented 7 years ago

I think they mean all light-emitting blocks, as I can reproduce it here; Same MC/C&B versions (also OptiFine), chiselling even a single bit out of a Glowstone Block causes it to no longer emit any light at all.

Haven't done an isolation test (just came across the issue and went to look), but I can do that later also if needed. Screenie attached to show.

2017-07-10_16 52 29

eriniki commented 7 years ago

Reproduced it with nothing but C&C and moreoverlays (and I can confirm it isn't moreoverlays, I tested without that first then realised I couldn't see the damn light levels without it, ahaha).

I'm aware the visual lack of fullbright/etc on the first test was just due to OptiFine w/ C&B blocks (and that's fine), but shouldn't chiseled glowstone still emit light? Hope this helps. :3

2017-07-10_19 52 35

AlgorithmX2 commented 7 years ago

This is a duplicate of https://github.com/AlgorithmX2/Chisels-and-Bits/issues/81 I think. If you place glowstone and remove it the situation fixes it self, its sort of an odd issue and I've yet to find a solution yet.

AlgorithmX2 commented 7 years ago

Ok.. I say that, but maybe I figured it out. if you want to try and confirm, https://www.dropbox.com/s/480k91kbzxfi92x/chiselsandbits-13.11.jar?dl=1

eriniki commented 7 years ago

I think you've nailed it.

That same original environment (optifine included, natch) with a single bit chiseled out keeps light perfectly 2017-07-12_03 07 47

And after chiseling it down to a single plane (to approach the 6.25 default on light-emitting) and then knocking bits out of it, it even scales the light level down. 2017-07-12_03 08 43

eriniki commented 7 years ago

Did some more testing (I was dead-tired then, and realised I had solely tested glowstone) - and it seems to work properly with everything I tested; Lamps, Fluids (e.g. lava and TE's energized Glowstone), other light-emitting mod blocks.

AlgorithmX2 commented 7 years ago

Thanks for helping test, This will definitely be in the next official release.

eriniki commented 7 years ago

Been busy as hell so I spaced out and forgot to reply (oops), but no worries! Was happy to help. Also, is this test build safe to use In The Wild (so to speak)? If so, I'll get it out to the folk on my server (so they can start using glowy bits again) soon, otherwise will wait for the official release. By safe also I mostly just mean in the way of regressions elsewhere/excess debug output still in, etc; I don't at all foresee any issues landing on your doorstep from it! :)

Thanks again for hopping on it so swiftly too, actually!

AlgorithmX2 commented 7 years ago

Sorry I didn't respond to this sooner, there is nothing to worry about with using that build. Feel free.