D3nnis3n
commented
6 years ago - MC Version: 1.12.2
- C&B Version: 14.8
- Do You have Optifine: Yes, as i can't play without resizing my 4K Resolution to lower values.
Closed D3nnis3n closed 6 years ago
D3nnis3n
commented
6 years ago D3nnis3n
commented
6 years ago Crosslinking: https://github.com/elytra/ArchitectureCraft/issues/11
Reproducable by having a chiseled block and placing an architecturecraft block on any of the direct adjacent sides.
D3nnis3n
commented
6 years ago If this is related to betterfoliage, as this is mentioned in the log, too, please tell me and i'll report it there, too. But i'm in no way able to see if this is the case in the log.
AlgorithmX2
commented
6 years ago BlockModelCustomizer and ConnectedTextures seem to be the issue, I did a little google searching and a few people reference that those are optifine classes.
There is no C&B Code in the stack trace, even though its a C&B Block.
I would suggest disabling optifine and see if the issue goes away, if it dose I would report it to OptiFine instead.
D3nnis3n
commented
6 years ago That is the case. I'll Report over there and link to here.
D3nnis3n
commented
6 years ago Well, i don't know what the "mods" Label means on Optifine, but does this mean the Optifine dev will look into it or does the think it's a Problem caused by the mods?
AlgorithmX2
commented
6 years ago I think it just means that its "related to mods"
sp614x
commented
6 years ago This is the code at the crash site:
// Get facing
EnumFacing facing = getFacing(side);
// Try with face quads
List quads = model.getQuads(neighbourState, facing, 0);
if(quads.size() > 0) // <------- CRASH here with NullPointerException
{
// The quad
BakedQuad quad = (BakedQuad) quads.get(0);
// The icon
return quad.getSprite();
}
Looks like the ArchitectureCraft block model returns null from getQuads(state, facing, 0) instead of a list. This method should always return a non-null value (empty list) as it is used without a null check everywhere in the vanilla and forge code.
D3nnis3n
commented
6 years ago So, is this issue fixed?
AlgorithmX2
commented
6 years ago I cannot reproduce a crash based on your instructions, so I can find no reason to keep it open.
My test instance included, architecturecraft-1.12-2.51 chiselsandbits-14.9.jar flatcoloredblocks-mc1.12-6.6.jar OptiFine_1.12.2_HD_U_C6_MOD.jar
D3nnis3n
commented
6 years ago Sphax wrote in this issue Why this is occuring oO
Am 01.12.2017 02:37 schrieb "AlgorithmX2" notifications@github.com:
I cannot reproduce a crash based on your instructions, so I can find no reason to keep it open.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AlgorithmX2/Chisels-and-Bits/issues/313#issuecomment-348376201, or mute the thread https://github.com/notifications/unsubscribe-auth/AYtVcBeuByr3Hay4Gyf-H3xWOb4NayjGks5s71hegaJpZM4Pxb6w .
AlgorithmX2
commented
6 years ago Yes, I've reviewed the chiseled block model, its impossible for its getQuad's method to return null, which is what caused the crash.
Which means that its not my model which is causing the crash. This is why I've not made any changes or fixes based on this issue in the time since sp614x replied, there is simply nothing for me personally to fix.
This is why I've closed the issue once I'd tested the crash by installing architecturecraft, chiselsandbits and optifine for 1.12.2, and I received no crash. Which means that either its fixed now, or another mod, not in that set is the cause.
Your mod list was rather large by comparison to my own, if your still seeing the issue, I would suggest reducing down your mod list to try an isolate it to another possible cause. Its possible another mod is interfering with other mods or optifine by altering other code or models between stages, for instance if my model returns normal data, another mod could examine my model, try to apply some extra logic to it some how, then produce a corrupted model instead.
The main point to be made here is that I see no way for myself to resolve this issue, if it even still exists.
D3nnis3n
commented
6 years ago Thanks for your detailed answer, that's all i wanted to know. I'll see what's going on. Thank you! :)