ChiselsAndBits / FlatColoredBlocks

A Minecraft mod about building with vast quantities of colored blocks.
http://minecraft.curseforge.com/projects/flat-colored-blocks
MIT License
20 stars 13 forks source link

Texture bug with Ender Compass mod (1.12) #45

Closed ImAK9 closed 7 years ago

ImAK9 commented 7 years ago

https://imgur.com/a/GXv4w & https://imgur.com/a/IlPdk

I have no idea why this happens.

ImAK9 commented 7 years ago

Ive reported it to the Ender Compass author too.

AlgorithmX2 commented 7 years ago

I cannot imagine why, The crafter icon / model use the standard asset system, nothing fancy just a JSON in the proper place that gets loaded like any item.

ImAK9 commented 7 years ago

So Ender Compass is the problem?

AlgorithmX2 commented 7 years ago

I can't say for certain, but based on the fact that the model assignment uses the simple JSON method, I'm inclined to say that that seems more likely, but I don't know how they are doing things either.

I honestly don't know anything about that mod.

ImAK9 commented 7 years ago

Well i disabled it for now, no way im disabling Flat colored blocks....

ImAK9 commented 7 years ago

It seem to fix it when i disabled it so my guess would be that Ender Compass is the problem here.

oitsjustjose commented 7 years ago

I wouldn't be so sure. I'm experiencing the same exact issue with Wearable Backpacks - and it doesn't do it on its own nor with any of the other mods installed (62 other mods). I will gladly provide more info if needed, but I think this is on FCB's end.

When are models being registered? I found that with the new registry system you have to do it in pre-init or else everything seems to get mad...

AlgorithmX2 commented 7 years ago

The Crafter item doesn't register any models, Forge/MC just loads the model on its own as is normal.

The blocks get their models assigned during the register block / item events. It didn't seem to work if I did it before that.

I honestly don't know, I spent 5 hours the other day trying to figure out why C&B's Tank won't render as an item, and I still have no idea.

oitsjustjose commented 7 years ago

Odd... well, if it helps any I too had to re-work all of my model registration for the new 1.12 system, maybe that'll help. It's particularly odd not having to register blocks but instead just ItemBlocks, but hey - it works.

AlgorithmX2 commented 7 years ago

This should be fixed now, calling setCustomModelResourceLocation before the item registration phase results in collisions of delegates.