ChiselsAndBits / FlatColoredBlocks

A Minecraft mod about building with vast quantities of colored blocks.
http://minecraft.curseforge.com/projects/flat-colored-blocks
MIT License
20 stars 13 forks source link

Crashes when opening creative menu. #46

Closed L0ST5ILVER closed 7 years ago

L0ST5ILVER commented 7 years ago

We have confirmed that this mod causes this problem, it goes like this: Download the newest version of FCB, opening the creative menu then clicking the [>] icon at the top, to change page, the game meets in unfortunate fate and crashes. I'm bringing this to your attention as soon as I found out, so I'm hoping you can have a fix out for it just as fast. Regards, -L0ST

AlgorithmX2 commented 7 years ago

I cannot reproduce this, please provide crash log.

L0ST5ILVER commented 7 years ago

I can't find the log. I'll try get it later.

brisingraerowing commented 7 years ago

@L0ST5ILVER I assume it is similar to this crash log.

AlgorithmX2 commented 7 years ago

@shadowfacts

https://github.com/shadowfacts/UnderwaterUtilities/blob/04396f411990433b3c0f3fb462e2062f70fb9fc9/src/main/kotlin/net/shadowfacts/underwaterutilities/block/tank/ItemBlockTank.kt#L30

Believe you need to add a method here,

for example: https://github.com/AlgorithmX2/Chisels-and-Bits/commit/fb38943bce9c30c09773f2b3b03036b147266960#diff-617810317411c8f3ddf74d4e39088abb

This method seems to have changed in 1.12 for some reason or another.

L0ST5ILVER commented 7 years ago

Okay!

shadowfacts commented 7 years ago

Indeed I do, I could have sworn I fixed that for all of my mods, but I guess I forgot one. A new version of UnderwaterUtilities will be out shortly.

AlgorithmX2 commented 7 years ago

I'll mark this as closed, unless @L0ST5ILVER has a second mod with the same problem. But I'll need a log to check on if that is the case.