search

Chitrank-Dixit / django-fcm

Django FCM provides firebase cloud messaging to android or ios support for django apps
https://django-fcm.readthedocs.io/en/latest/
MIT License
54 stars 28 forks source link

add missing migrations #12

Closed andpozo closed 8 years ago

andpozo commented 8 years ago

Resolve this issue #10

Chitrank-Dixit commented 8 years ago

I think we should not add migrations to django-fcm, because the initial migration would be for the users as soon as they install it, but when they make a change to the device model and then run migration again it would make a second migration, so this second migration would also be made in the site-packages, where the module resides, and if some app's migration has this second module dependency then it would be confusing and conflicting, because people will be pushing there migrations in their app, and along with that second migration with timestamped name would be there and for the other developer when they run makemigration that migration name would be different,

well one alternative to this is to use name for the second migration but that names should be shared between developers and they need to add this migration creation in their developer documentation.

andpozo commented 8 years ago

@Chitrank-Dixit the migrations should be declared for the model inside the django-fcm, if one user needs change default model, would be declared in other app (e.g. custom-fcm) with their migrations, BTW any app needs their migrations

andpozo commented 8 years ago

like a django project -> https://github.com/django/django/tree/master/django/contrib/auth/migrations