search

Chitrank-Dixit / django-fcm

Django FCM provides firebase cloud messaging to android or ios support for django apps
https://django-fcm.readthedocs.io/en/latest/
MIT License
54 stars 28 forks source link

Bad inheritance #35

Closed rmanganiello closed 1 year ago

rmanganiello commented 7 years ago

I don't understand why FCMMessage class inheritance from FCMMessage (with the same name) and reuse the super "send" method. Why don't you unify all the logic inside the same class with differents methods or rename base FCMMessage class?

https://github.com/Chitrank-Dixit/django-fcm/blob/master/fcm/utils.py#L99-L110

Chitrank-Dixit commented 7 years ago

updating this in the next coming release