ChloeDawn / Bamboozled

A mod for Minecraft that adds bamboo and various other content
Apache License 2.0
2 stars 3 forks source link

Halite generation efficiency (again) #8

Open Laike-Endaril opened 5 years ago

Laike-Endaril commented 5 years ago

I'm sure it's probably more efficient than it used to be, since you addressed this once already (#3), but bamboozled is still getting the top slot in event handler tick times for me (which I found very surprising until I remembered it had halite and not just bamboo).

In addition to the event handler tick time, lag goggles is also showing some high tick times on a few select water blocks underground, near halite, which I assume is connected to their generation as well.

I do like the unique generation procedure for halite, but with efficiency in mind, would you be interested in a config option to choose the generation mode? Ie. "Advanced Halite Gen" (t/f) or something along those lines. If set to true, it uses the current method, but if false, it just uses your average oregen instead?

Here are some screenshots; you can clearly see it's having a larger impact than...well...every other mod in the event handler section. The BlockStaticLiquid time also belongs to halite gen (I ran another test after disabling salt gen and it disappeared from the list):

https://ibb.co/syJg8tv

For now, I will keep salt gen disabled. Maybe I'll add it to some loot tables as a temporary alternative method of acquirement

ChloeDawn commented 4 years ago

Apologies for the delays in responding to this, I'm still working on the new update and it's been a slow process because my real life has been taking priority lately. I should hopefully have the 3.0.0 update out sometime over Christmas / the beginning of the new year, and both the halite and bamboo generation have been significantly optimized. ^^

Laike-Endaril commented 4 years ago

Np; I've been pretty busy on my own mod projects lately, so I haven't had time to work on my modpack either. Probably won't for several more months at least