search

ChloePrime / AAAParticles

Effekseer loader on Minecraft 1.18+
MIT License
14 stars 6 forks source link

Culling support #26

Closed DadamaldaDad closed 2 months ago

DadamaldaDad commented 2 months ago

Culling currently doesn't work. Implementing at least view frustum culling would be awesome for performance with lots of particles.

View frustum culling means not rendering particles outside the player's view.

ChloePrime commented 2 months ago

It's inside the C++ code in Effekseer, which is out of my control

DadamaldaDad commented 2 months ago

That's sad. I thought view frustum culling could work because it just needs the FOV, window size, camera location and angle. Effekseer itself supports it.

ChloePrime commented 2 months ago

Oh I see a Java function in Effekseer Swig API that can accept camera parameters. Maybe calling it will enable frustum culling

ChloePrime commented 2 months ago

Try 1.3.1

DadamaldaDad commented 2 months ago

This sadly didn't fix anything. It's not on Modrinth (which doesn't matter at this point) and the version number is messed up.

DadamaldaDad commented 2 months ago

You can close this as not planned if you want.

ChloePrime commented 2 months ago

Not planned, btw 1.3.1 is on Modrinth now :)