ChluNetwork / chlu-ipfs-support

Support libs to talk to IPFS
MIT License
1 stars 1 forks source link

Detect if a review is from a different chlu network #100

Open fazo96 opened 6 years ago

fazo96 commented 6 years ago

This would avoid issues where getting a review from a blockchain tx shows up as invalid but really it's just because it's from a different chlu network

Ideally the validator should figure it out and return a "wrong chlu network" error.

Also, the cache should be namespaced by chlu network or cleared on network change or something

fazo96 commented 6 years ago

use some bits in chlu_version to namespace the network, check this when reading and ignore if the network is different

fazo96 commented 6 years ago

Update: we should instead create a new field in the protobuf called chlu_network

https://github.com/ChluNetwork/chlu-ipfs-support/pull/116#discussion_r209250337