search

ChluNetwork / chlu-ipfs-support

Support libs to talk to IPFS
MIT License
1 stars 1 forks source link

disable keeping track of lastreviewrecord multihash #120

Closed fazo96 closed 6 years ago

fazo96 commented 6 years ago

This feature was not used anywhere.

The problem is that it breaks the delegation of publishing reviews to a server, so I disabled this feature for the moment to keep the option of publishing through servers open.

We can reintroduce this later when it actually serves a purpose

@kulpreet what do you think?

kulpreet commented 6 years ago

@fazo96 I'd rather have this merged only if we are doing delegation to publishing server. The hash pointers to previous reviews are important to maintain.

fazo96 commented 6 years ago

@kulpreet I want to keep the delegation to publish server option open, the hash pointers are not used now so why keep them anyway? We can always reintroduce them.

If you want to build an ordered list of reviews submitted by a user you can look at the orbitdb oplog to get it

kulpreet commented 6 years ago

The logical timestamps for reviews is part of the protocol to avoid competing vendors being able to purchase reviews and update them to be bad reviews. Since that is a core part of the protocol, I'd like to try and keep it in.

fazo96 commented 6 years ago

Cool, will close this then and we will use ChluIPFS to do the publishing of reviews on the frontend.