ChluNetwork / chlu-ipfs-support

Support libs to talk to IPFS
MIT License
1 stars 1 forks source link

Add a module to validate a review #27

Closed kulpreet closed 6 years ago

kulpreet commented 6 years ago

This module can be used by marketplaces to validate a discovered review. The validation is specified here - https://github.com/ChluNetwork/chlu-protocol/blob/master/chlu_protocol.md#validating-a-review

fazo96 commented 6 years ago

List of validations that we need to perform (roughly in order):

Basic validation (no signing/encryption stuff, no blockchain stuff)

Blockchain validation

Signing/encryption validation

Also we should add an option to fail the validation if the signature or the encryption is missing

kulpreet commented 6 years ago

We need the PoPR to be signed. To achieve that we need to do the key setup part first. But for the first demo, lets put in a mock PoPR validation function that returns true.

fazo96 commented 6 years ago

Updated comment with the validations that I split out from PR #37

fazo96 commented 6 years ago

@kulpreet Closing this and moving the blockchain stuff to a new issue #85