ChluNetwork / chlu-ipfs-support

Support libs to talk to IPFS
MIT License
1 stars 1 forks source link

EventEmitter memory leak #51

Closed fazo96 closed 6 years ago

fazo96 commented 6 years ago

It is caused by every call to readReviewRecord with update checks subscribing to events from the user's db. We need to change this so that it subscribes to chluIpfs' internal event emitter instead.

Also, notifyUpdate should not be passed to readReviewRecord anymore and instead registered once as a callback for all review updates. Then a checkForUpdates fn is passed if the customers' orbitDb should be opened when reading a RR