Closed fazo96 closed 6 years ago
@fazo96 about
IPFS Utils module: has new functions to put/get objects as JSON in IPFS. This is because the DIDs are stored in IPFS using the dag-pb format with a string with json inside. Instead, the other data structures are stored with dag-pb and our protobuf encoded binaries inside
Should we not try to align these?
IPFS Utils module: has new functions to put/get objects as JSON in IPFS. This is because the DIDs are stored in IPFS using the dag-pb format with a string with json inside. Instead, the other data structures are stored with dag-pb and our protobuf encoded binaries inside
Should we not try to align these?
@kulpreet good point, here's how it works now
object --> protobuf binary buffer (using our protobufs) --> (we enter IPFS logic here) dag-pb binary buffer --> IPFS
Let's not focus on unverified reviews in this PR, but I'm including this to be thorough
object --> String (using JSON.stringify) --> utf-8 encoded binary buffer --> (we enter IPFS logic here) dag-pb binary buffer --> IPFS
object --> String (using JSON.stringify) --> utf-8 encoded binary buffer --> (we enter IPFS logic here) dag-pb binary buffer --> IPFS
@kulpreet We can either use JSON for Verified Reviews or we write/use protobufs for DIDs and Unverified Reviews. I'd go for JSON but I trust your judgement more on these kind of things, so it's up to you and I think you said on slack we'll go with protobufs
About Unverified Reviews, I'd leave that out of this PR and just focus on DIDs for now
Big changes to the whole implementation to drop keypairs in favor of a Distributed IDentity system for identifying Vendors, Marketplaces and Customers.
The Vendor-Marketplace cosigned key is still a key using the old system and not a DID.
Most impacted internal modules:
signReviewRecord
Impact in other projects:
Other projects will need to be updated for these changes
What's missing
key_location
and fields like that should not be used for DIDs like they are in this version, I should use new protobuf fields (following our short discussion on slack). I forgot to do this before submitting the PRwe should also get orbit-db to use the DID keypair for its own signing operationsno, better push this to later. DID get operations should then verify the signature