Closed fazo96 closed 6 years ago
Quick one about the signature type. We need to switch to a well know signature suite. I created a card here https://trello.com/c/MhYIkZlY, we can discuss what this means for the current choices and what we need to change.
Status is that it works, tests are passing, but it needs cleanup
Notes for discussion
deprecated optional fields are problematic, I removed them. We should also rename some other fields that were named not to conflict with existing deprecated fields (likesig
)or we could create a separate IPFS datastructure for the vendor-marketplace key that contains these signatures so they are not repeated in all review recordsverifiable
useless? just check ifverification
is present and make it optional// vendor key location and vendor encryption key location should resolve from the did
vendor_did
field is enoughwhen signing, we calculate the internal hash of PoPR/RR and then create the signature and set it. When we calculate the internal hash we remove the signature. The sig fields are however required, so we have to set a bogus/empty constant signature. The quick solve is to make signatures not required in the protobufsignature.type
what should we put? Signature algorithm should go hereother protobuf libraries not tested yetstick with protons for nowIssues
importUnverifiedReviews
is inefficient https://github.com/ChluNetwork/chlu-ipfs-support/issues/95Switching protocol buffer library