search

ChluNetwork / chlu-ipfs-support

Support libs to talk to IPFS
MIT License
1 stars 1 forks source link

make importUnverifiedReviews faster and atomic #95

Open fazo96 opened 6 years ago

fazo96 commented 6 years ago

This will need changes to publish logic so that a batch publish is possible.

The current method is not atomic because it calls storeReviewRecord indivually on reviews, and fails if one of the calls fail, leaving the user with a partially imported reputation.

kulpreet commented 6 years ago

We might need to make it idempotent, so we can run it again, or track which ones failed, so that we only try to save the ones that failed.

Also, I think this will change with the http gateway approach were are taking. Should we close this then?

fazo96 commented 6 years ago

I think this will change with the http gateway approach were are taking. Should we close this then?

Depends on how we want to handle it if I import 10 reviews and one fails

Making it idempotent would be cool but is related to #94