ChoGGi / CuteButtons

Adds icons to buttons and/or menus (Firefox, Thunderbird, SeaMonkey, Palemoon).
https://addons.mozilla.org/addon/5878/
9 stars 1 forks source link

CB fails on checkboxes when importing address book #9

Closed stonecrusher closed 6 years ago

stonecrusher commented 6 years ago

Thunderbird 52.9.1 (32-Bit) CuteButtons 0.5.6

Importing a .csv addressbook: How it looks 2018-08-13 00_14_08-adressbuch importieren

How it really is 2018-08-13 00_15_11-adressbuch importieren

ChoGGi commented 6 years ago

Updated https://github.com/ChoGGi/CuteButtons/commit/9802d8bbee52fe9806a84d9e9b5f717202511f59 https://addons.palemoon.org/addon/cutebuttons/

stonecrusher commented 6 years ago

Hmm, something is strange. The version from the Palemoon site doesn't work for me in TB 52.9.1 I can install it but no icons are added anywhere.

I guess it's just not the latest version 0.5.8 because it explicitly says 0.5.7 despite having modification date of today.

BUT when I reinstalled 0.5.6 it also doesn't work anymore :-/

ChoGGi commented 6 years ago

Where do you see 0.5.8? When you press ctrl-shift-j do you see any error msgs from cutebuttons show up?

I'm not able to repro it so https://imgur.com/w03REF8

stonecrusher commented 6 years ago

Where do you see 0.5.8?

here, new line 10: https://github.com/ChoGGi/CuteButtons/commit/9802d8bbee52fe9806a84d9e9b5f717202511f59#diff-ae6d2e248891adb1f4f0c83b6fba128dR10

When you press ctrl-shift-j do you see any error msgs from cutebuttons show up?

There are some, but I think the only one related to CB is NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.lastModifiedTime] common.jsm:203 and relates to

if (cbCommon.prefs.getIntPref(pref) != mosaic) {
      //numbers don't match; no need to check file existence/date, just copy and call it a day (mosaic changed)
      cbCommon.copyFile(fileAddon,fileProfile,nameProfile);
      //update mosaicWhich so we aren't copying the same file all the time
      cbCommon.prefs.setIntPref(pref,mosaic);
// NEXT LINE IS RELATED TO ERROR
    } else if (fileProfile.lastModifiedTime != fileAddon.lastModifiedTime) {
      //profile file time is different from addon file time (extension updated)
      cbCommon.copyFile(fileAddon,fileProfile,nameProfile);
    } else if (fileProfile.exists() == false) {
      //if it doesn't exist (first run)
      fileAddon.copyTo(cbCommon.profileDir,nameProfile);
    }
ChoGGi commented 6 years ago

Yeah, that's on github, it isn't in a release.

I see the issue now though, thanks fixed https://addons.palemoon.org/addon/cutebuttons/

stonecrusher commented 6 years ago

Thank you, now everything works as expected.