Choate-Robotics / 7407-DriveCode-Crescendo

This is the DriveCode for 2024 FRC game Crescendo.
3 stars 2 forks source link

Feat/intake #54

Closed e-bauman closed 8 months ago

mbardoe commented 9 months ago

@e-bauman Here are a few notes from our code Review

Put config in the config file Double check motor config syntax

Outer motor back and front should just be outer_motor Delete commented code please Line 74 creating variable is redundant, just return What is the point of idle_speed?

e-bauman commented 8 months ago

idle_speed is because we are going to have the intake idly spinning when it is not actively intaking. When we don't have a note, it will idly spin in and increase in speed when we detect a note, when we do have a note, it will idly spin out so we don't accidentally pick up another note.

In the detect_note function, I am not making a new variable, I am changing the state of the subsystem variable note_in_intake.

I made the other changes from the code review