Open ChocoRagdoll opened 3 months ago
Thank you for the feedback. We should have included the note for this diagram. However, this issue is not present for all command sequence diagrams, only the editCommand and viewCommand sequence diagrams. For example, this is explained in other diagrams.
Therefore, we believe that most developers reading the developer guide would be familiar with this notation and understand it. As such, we believe that this should be classified as severity.low instead.
Team chose [severity.Low
]
Originally [severity.Medium
]
Reason for disagreement: [replace this with your explanation]
In the sequence diagrams of the commands, the command parser (in the above case, the
EditCommandParser
) has a lifeline that extends beyond the cross, which is supposed to signify the end of the object's lifeline.This is due to the limitation of the puml diagrams, but the absence of an explanation may make the diagram confusing for the fellow engineers working on this project.
Since this issue is present for all the command sequence diagrams, I will tag this as medium.