search

Chocobozzz / OpenVPN-Admin

Install and administrate OpenVPN with a web interface (logs visualisations, users managing...)
GNU Affero General Public License v3.0
947 stars 368 forks source link

[proposal] rewrite in Laravel #78

Open okaufmann opened 6 years ago

okaufmann commented 6 years ago

Hi guys,

I really like your project, I'm using on a Raspberry Pi to connect to a private network.

What do you think about a rewrite in Laravel? I like to do this anyway to have easier Database handling (and multiple options like postgres, sqlite out of the box).

Furthermore issues like: https://github.com/Chocobozzz/OpenVPN-Admin/issues/73 and https://github.com/Chocobozzz/OpenVPN-Admin/issues/14 could be realized in a generally known way (maybe add support for SMS 2FA?).

The Installation could be started with a build in cli right out of the project.

And at the end, I think it's easier to contribute to a Project made with a well known framework like Laravel, than a plain PHP application.

What do you think?

serjoscha87 commented 6 years ago

I'm not a maintainer or something, I just came along here. But I think this may be massively beyond purpose.

Chocobozzz commented 6 years ago

I don't think using a PHP framework for 400 lines of code would be a good idea even if you have good arguments. I don't know Laravel and I don't have time so I won't rewrite the project. But if you want to do this and if the result is good I would be happy to merge your work.

AlexH-HankIT commented 6 years ago

@Chocobozzz I think it's a good idea. Especially stuff like LDAP Authentication can be easily integrated, if one is using laravel. We could even build in support for remote servers via ssh. I already wrote a library which abstracts this. So for example after the installation the user could choose, if he wants to add the local or a remote server (or multiple for that matter).

Would you even be interested in such huge changes? If you don't have laravel experience, there is not much sense in migrating your project over to it.

I personally think this could greatly benefit from it though.

@okaufmann Are you interested in helping me out here?