search

Chocobozzz / PeerTube

ActivityPub-federated video streaming platform using P2P directly in your web browser
https://joinpeertube.org/
GNU Affero General Public License v3.0
13.07k stars 1.5k forks source link

Videos do not play when requesting the desktop website on iOS #2941

Closed Crestwave closed 4 years ago

Crestwave commented 4 years ago

What happened?

It got stuck loading videos on iOS when requesting the desktop website; it downloads but never plays.

What do you expect to happen instead?

It should play since this is actually the default for iPadOS; I have this setting turned off myself, but my friend couldn't play a video I uploaded and I found out that it was because of this. Note that it works perfectly on the mobile website.

Steps to reproduce:

  1. Either have Settings > Safari > Request Desktop Website > All Websites set to on (default on iPadOS) or press the aA icon on the URL bar then Request Desktop Website.

  2. Try to play a video.

Additional information

imc67 commented 4 years ago

Hi, is there any progress on this bug? We’ve waited for 2.3 to solve some bugs, now we can almost go live with our (1000+ own videos) PeerTube but this bug is for us a show stopper. Most of our audience is using iPad as device.

gramakri commented 4 years ago

@Chocobozzz Do you have a hunch what causes this problem?

rigelk commented 4 years ago

I tried a few local and remote videos on the instance from a 2018 iPad using Safari, iOS 12. Videos are playing fine. Do you have a more specific video I could test to replicate the problem?

imc67 commented 4 years ago

With iPad Pro on iOS 13.6 every video on every PeerTube is not playing. The twitch is that in Safari “request desktop site” is defaulted, that is not working with PeerTube. If you manually request a “mobile site” then it does work.

tcitworld commented 4 years ago

On iPadOS 14 videos on Chrome work properly, but most of the time fail to load in Safari or Firefox Focus, and never on Firefox.

Crestwave commented 4 years ago

Note that unless it changed in iOS 14, all browsers on iOS use the same engine. The main issue seems to be the user agent or something; requesting a desktop site makes it use a macOS user agent, which I'm guessing causes some difference that breaks it.

Here's mine: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.1 Safari/605.1.15

P.S. "iPadOS" is essentially iOS 13+ on iPad, which is why you don't have this issue by default on iOS 12. You might still encounter it if you manually request it, though

Chocobozzz commented 4 years ago

Thanks, should be fixed by https://github.com/Chocobozzz/PeerTube/commit/b6a8cfc5714c93d0ecf6154e5d3a25b33b50b8cd

tdiglx commented 4 years ago

Some viewers using iOS and Safari reported problems viewing embedded videos. Could applying the commits diff to Peertube 2.3 fix the problem for them or would I need to add other diffs as well?

Chocobozzz commented 4 years ago

Replace isIOS() function with https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/assets/player/utils.ts#L11 should work

tdiglx commented 4 years ago

Thanks!

tdiglx commented 4 years ago

Sorry to return to this issue after such a long pause. We tried to apply the patch to the git-sources of PeerTube (to the v2.3.0 tag checkout) and then compile / install the code following the guide in https://github.com/Chocobozzz/PeerTube/issues/33. The iOS devices had no problems afterwards, but when logging in we got an error message ("Cannot read property 'res' of undefined") so we had to switch back to the released tar-archive version of PeerTube.