Chocobozzz / PeerTube

ActivityPub-federated video streaming platform using P2P directly in your web browser
https://joinpeertube.org/
GNU Affero General Public License v3.0
13.08k stars 1.51k forks source link

Gravatar integration #3378

Closed madmath03 closed 2 years ago

madmath03 commented 3 years ago

Describe the problem to be solved

New users could get their profile picture retrieved automatically based on their email address.

Describe the solution you would like:

A Gravatar integration to PeerTube. Of course, it should be possible to disable this integration in order to not send user email address to an external service.

Describe alternatives you have considered

It would probably be better as a plugin, but I'm not sure PeerTube currently has the hooks available for such a plugin.

rigelk commented 3 years ago

hi @madmath03 and thanks for the suggestion!

You might be interested by https://www.libravatar.org/ as an alternative.

Of course, it should be possible to disable this as it could violate some privacy policies.

I'm not sure we want privacy to be opt-in…

It would probably be better as a plugin, but I'm not sure PeerTube currently has the hooks available for such a plugin.

You are welcome to request the needed hooks.

madmath03 commented 3 years ago

I'm not sure we want privacy to be opt-in…

What I meant is that we should be able to disable a Gravatar like integration because such integrations require to send the user email to an external service. Some instances might prefer to disable this feature to keep their email fully private.

I will rephrase the description.

You are welcome to request the needed hooks.

I'm still discovering PeerTube so I might be wrong and I'm not sure what's the best approach so feel free to comment the following proposal:

Solution would be to have some kind of getAvatar hook that would be called before getting a user's avatar:

Reference: https://github.com/Chocobozzz/PeerTube/blob/develop/support/doc/plugins/guide.md#hooks

What do you think @rigelk ? Is that a good enough solution and description for such a hook ? Should this be kept here or moved into a separate issue ?

Chocobozzz commented 2 years ago

Hello,

If you interested in developing such plugin but you're missing hooks/API, please create dedicated issues.

madmath03 commented 2 years ago

Hello,

If you interested in developing such plugin but you're missing hooks/API, please create dedicated issues.

It was not a matter of available hooks or API, but a matter of time. This issue/feature request should still be relevant.