search

Chocobozzz / PeerTube

ActivityPub-federated video streaming platform using P2P directly in your web browser
https://joinpeertube.org/
GNU Affero General Public License v3.0
13.09k stars 1.51k forks source link

Unable to embed Unlisted videos #4947

Closed smilekison closed 2 years ago

smilekison commented 2 years ago

Describe the current behavior

While sharing the video with setting unlisted. I am getting the 403 error. not-public

Steps to reproduce:

  1. Upload any video with privacy setting unlisted.
  2. Open embed service with url: https://example.com/services/oembed?url=https://example.com/w/8WsRJsTtgAAJ2B7fSH2QTA

Describe the expected behavior While sharing the link directly, I am able to play the video on the browser. So, I think i should be able to embed the video and get preview. public-setting

I found this code on PeerTube. According to this, I think i should be able to get the video preview of the unlisted video file as long as the video UUID is valid. Screenshot from 2022-04-28 11-24-52

* PeerTube instance:
  * version: 4.1.1
  * NodeJS version: v14.19.1
  * Ffmpeg version: 4.2.4-1ubuntu0.1
Chocobozzz commented 2 years ago

Thanks, it should be fixed by https://github.com/Chocobozzz/PeerTube/commit/b3d9dedcc36a333bae0bafe92eeede1a11796ce7