Chocobozzz / PeerTube

ActivityPub-federated video streaming platform using P2P directly in your web browser
https://joinpeertube.org/
GNU Affero General Public License v3.0
13.09k stars 1.51k forks source link

peertube-import-videos.js return expected 200 "OK", got 413 "Payload Too Large" #5069

Closed Tr4sK closed 2 years ago

Tr4sK commented 2 years ago

Describe the current behavior

I want to import video from a youtube channel but it fail with 413 Payload too large

Steps to reproduce

$ git status                                                                    
On branch release/4.2.0
Your branch is up to date with 'origin/release/4.2.0'.

nothing to commit, working tree clean
$ NOCLIENT=1 yarn install --pure-lockfile
yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
success Already up-to-date.
$ test -n "$NOCLIENT" || (cd client && yarn install --pure-lockfile)                                                                                                                                      [257/1847]
Done in 0.75s.
[tr4sk@x230server PeerTube]$ npm run setup:cli

> peertube@4.2.0 setup:cli
> bash ./scripts/setup/cli.sh

yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
success Already up-to-date.
$ test -n "$NOCLIENT" || (cd client && yarn install --pure-lockfile)
Done in 0.74s.
yarn install v1.22.19
[1/4] Resolving packages...
success Already up-to-date.
Done in 0.11s.
[9:00:26 AM] Projects in this build: 
    * ../../shared/tsconfig.json
    * ../tsconfig.json
    * tsconfig.json

[9:00:26 AM] Project '../../shared/tsconfig.json' is out of date because oldest output '../../dist/shared/core-utils/index.js' is older than newest input '../../shared/models/plugins/client/client-hook.model.ts'

[9:00:26 AM] Building project '/home/tr4sk/PeerTube/shared/tsconfig.json'...

[9:00:31 AM] Updating unchanged output timestamps of project '/home/tr4sk/PeerTube/shared/tsconfig.json'...

[9:00:31 AM] Project '../tsconfig.json' is out of date because oldest output '../../dist/server/controllers/bots.js' is older than newest input '../../shared'

[9:00:31 AM] Building project '/home/tr4sk/PeerTube/server/tsconfig.json'...

[9:01:03 AM] Updating unchanged output timestamps of project '/home/tr4sk/PeerTube/server/tsconfig.json'...

[9:01:03 AM] Project 'tsconfig.json' is out of date because output file '../../dist/server/tools/cli.js' does not exist

[9:01:03 AM] Building project '/home/tr4sk/PeerTube/server/tools/tsconfig.json'...

> peertube@4.2.0 resolve-tspaths:cli
> npm run resolve-tspaths -- --project ./server/tools/tsconfig.json --src ./server/tools --out ./dist/server/tools

> peertube@4.2.0 resolve-tspaths
> resolve-tspaths "--project" "./server/tools/tsconfig.json" "--src" "./server/tools" "--out" "./dist/server/tools"

resolve-tspaths: changed 3 file(s)

> peertube@4.2.0 resolve-tspaths:server
> npm run resolve-tspaths -- --project tsconfig.json --src . --out dist

> peertube@4.2.0 resolve-tspaths
> resolve-tspaths "--project" "tsconfig.json" "--src" "." "--out" "dist"

resolve-tspaths: changed 522 file(s)

$ node dist/server/tools/peertube-import-videos.js -u "$PTINSTANCE" -U $PTUSER --password $PTPWD --target-url $YTURL

info: ############################################################                                                                                                                                                  

info: Downloading video "How would Iran retaliate?"...                                                                                                                                                              
info: [youtube] 0bMIn1bckDs: Downloading webpage                                                                                                                                                                    
[youtube] 0bMIn1bckDs: Downloading android player API JSON                                                                                                                                                          
[info] 0bMIn1bckDs: Downloading 1 format(s): 136+140                                                                                                                                                                
[download] Destination: /home/tr4sk/PeerTube/dist/server/tools/48b0d5ae9c4ac26605fa0405dbe453bc1840d33e7c94f75d45af4ed4fd146c0b.f136.mp4                                                                            
[download] 100% of 40.67MiB in 00:04                                                                                                                                                                                
[download] Destination: /home/tr4sk/PeerTube/dist/server/tools/48b0d5ae9c4ac26605fa0405dbe453bc1840d33e7c94f75d45af4ed4fd146c0b.f140.m4a                                                                            
[download] 100% of 4.74MiB in 00:00                                                                                                                                                                                 
[Merger] Merging formats into "/home/tr4sk/PeerTube/dist/server/tools/48b0d5ae9c4ac26605fa0405dbe453bc1840d33e7c94f75d45af4ed4fd146c0b.mp4"                                                                         
Deleting original file /home/tr4sk/PeerTube/dist/server/tools/48b0d5ae9c4ac26605fa0405dbe453bc1840d33e7c94f75d45af4ed4fd146c0b.f136.mp4 (pass -k to keep)                                                           
Deleting original file /home/tr4sk/PeerTube/dist/server/tools/48b0d5ae9c4ac26605fa0405dbe453bc1840d33e7c94f75d45af4ed4fd146c0b.f140.m4a (pass -k to keep)                                                           
info:                                                                                                                                                                                                               
Uploading on PeerTube video "How would Iran retaliate?".                                                                                                                                                            
expected 200 "OK", got 413 "Payload Too Large"
]$ ls -lah /home/tr4sk/PeerTube/dist/server/tools/48b0d5ae9c4ac26605fa0405dbe453bc1840d33e7c94f75d45af4ed4fd146c0b.mp4
-rw-r--r-- 1 tr4sk tr4sk 46M Oct 29  2014 /home/tr4sk/PeerTube/dist/server/tools/48b0d5ae9c4ac26605fa0405dbe453bc1840d33e7c94f75d45af4ed4fd146c0b.mp4

Describe the expected behavior

No response

Additional information

Chocobozzz commented 2 years ago

Hi,

Could you find server logs to know which endpoint returns 413?

Tr4sK commented 2 years ago

docker-compose logs

peertube-peertube-1   | [tube.tr4sk.me:443] 2022-06-21 09:41:52.958 ESC[32minfoESC[39m: 192.168.2.5 - - [21/Jun/2022:09:41:52 +0000] "GET /api/v1/search/videos?search=How%20would%20Iran%20retaliate%3F&sort=-match
peertube-peertube-1   | [tube.tr4sk.me:443] 2022-06-21 09:41:55.080 ESC[32minfoESC[39m: 192.168.2.5 - - [21/Jun/2022:09:41:55 +0000] "GET /api/v1/oauth-clients/local HTTP/1.0" 200 99 "-" "-"
peertube-peertube-1   | [tube.tr4sk.me:443] 2022-06-21 09:41:55.907 ESC[32minfoESC[39m: 192.168.2.5 - - [21/Jun/2022:09:41:55 +0000] "POST /api/v1/users/token HTTP/1.0" 200 194 "-" "-"
peertube-peertube-1   | [tube.tr4sk.me:443] 2022-06-21 09:41:56.579 ESC[32minfoESC[39m: 192.168.2.5 - - [21/Jun/2022:09:41:56 +0000] "GET /api/v1/video-channels/caspianreport HTTP/1.0" 200 2912 "-" "-"

And I see that in

docker-compose exec -it webserver less /var/logs/nginx/peertube.error.log

2022/06/21 09:42:34 [error] 682#682: *705132 client intended to send too large body: 47973812 bytes, client: 192.168.2.5, server: tube.tr4sk.me, request: "POST /api/v1/videos/upload HTTP/1.1", host: "tube.tr4sk.m
e"

docker-compose exec -it webserver less /var/logs/nginx/peertube.access.log

192.168.2.5 - - [21/Jun/2022:09:42:34 +0000] "POST /api/v1/videos/upload HTTP/1.1" 413 183 "-" "-"
Chocobozzz commented 2 years ago

Can you paste docker-volume/nginx/peertube content?

Tr4sK commented 2 years ago
# Minimum Nginx version required:  1.13.0 (released Apr 25, 2017)
# Please check your Nginx installation features the following modules via 'nginx -V':
# STANDARD HTTP MODULES: Core, Proxy, Rewrite, Access, Gzip, Headers, HTTP/2, Log, Real IP, SSL, Thread Pool, Upstream, AIO Multithreading.
# THIRD PARTY MODULES:   None.

#server {
#  listen 80;
#  listen [::]:80;
#  server_name ${WEBSERVER_HOST};
#
#  location /.well-known/acme-challenge/ {
#    default_type "text/plain";
#    root /var/www/certbot;
#  }
#  location / { return 301 https://$host$request_uri; }
#}

upstream backend {
  server ${PEERTUBE_HOST};
}

server {
  listen 80;
  listen 81 proxy_protocol;
  listen 82 proxy_protocol http2;
  listen [::]:80;
  listen [::]:81 proxy_protocol;
  listen [::]:82 proxy_protocol http2;
  server_name ${WEBSERVER_HOST};

  access_log /var/log/nginx/peertube.access.log combined buffer=10m flush=5m; # reduce I/0 with buffer=10m flush=5m
  error_log  /var/log/nginx/peertube.error.log;

  set_real_ip_from 192.168.0.0/24;     # Set IP or subnet of your Loadbalancers here
  real_ip_recursive on;
  real_ip_header   proxy_protocol;  # This is mandatory to get Real IP from Proxy Protocol (other server block on port: 80 can continue use real_ip module with header: X-Forwarded-For)
  ##
  # Certificates
  # you need a certificate to run in production. see https://letsencrypt.org/
  ##
  #ssl_certificate     /etc/letsencrypt/live/${WEBSERVER_HOST}/fullchain.pem;
  #ssl_certificate_key /etc/letsencrypt/live/${WEBSERVER_HOST}/privkey.pem;

  location ^~ '/.well-known/acme-challenge' {
    default_type "text/plain";
    root /var/www/certbot;
  }

  ##
  # Security hardening (as of Nov 15, 2020)
  # based on Mozilla Guideline v5.6
  ##

  #ssl_protocols             TLSv1.2 TLSv1.3;
  #ssl_prefer_server_ciphers on;
  #ssl_ciphers               ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256; # add ECDHE-RSA-AES256-SHA if you want compatibility with Android 4
  #ssl_session_timeout       1d; # defaults to 5m
  #ssl_session_cache         shared:SSL:10m; # estimated to 40k sessions
  #ssl_session_tickets       off;
  #ssl_stapling              on;
  #ssl_stapling_verify       on;
  # HSTS (https://hstspreload.org), requires to be copied in 'location' sections that have add_header directives
  #add_header Strict-Transport-Security "max-age=63072000; includeSubDomains";

  ##
  # Application
  ##

  location @api {
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header Host            $host;
    proxy_set_header X-Real-IP       $remote_addr;

    client_max_body_size  100k; # default is 1M

    proxy_connect_timeout 10m;
    proxy_send_timeout    10m;
    proxy_read_timeout    10m;
    send_timeout          10m;

    proxy_pass http://backend;
  }

  location / {
    try_files /dev/null @api;
  }

  location = /api/v1/videos/upload-resumable {
    client_max_body_size    0;
    proxy_request_buffering off;

    try_files /dev/null @api;
  }

  location = /api/v1/videos/(upload|([^/]+/studio/edit))$ {
    limit_except POST HEAD { deny all; }

    # This is the maximum upload size, which roughly matches the maximum size of a video file.
    # Note that temporary space is needed equal to the total size of all concurrent uploads.
    # This data gets stored in /var/lib/nginx by default, so you may want to put this directory
    # on a dedicated filesystem.
    client_max_body_size                      12G; # default is 1M
    add_header            X-File-Maximum-Size 8G always; # inform backend of the set value in bytes before mime-encoding (x * 1.4 >= client_max_body_size)

    try_files /dev/null @api;
  }

  location ~ ^/api/v1/(videos|video-playlists|video-channels|users/me) {
    client_max_body_size                      6M; # default is 1M
    add_header            X-File-Maximum-Size 4M always; # inform backend of the set value in bytes before mime-encoding (x * 1.4 >= client_max_body_size)

    try_files /dev/null @api;
  }

  ##
  # Websocket
  ##

  location @api_websocket {
    proxy_http_version 1.1;
    proxy_set_header   X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header   Host            $host;
    proxy_set_header   X-Real-IP       $remote_addr;
    proxy_set_header   Upgrade         $http_upgrade;
    proxy_set_header   Connection      "upgrade";

    proxy_pass http://backend;
  }

  location /socket.io {
    try_files /dev/null @api_websocket;
  }

  location /tracker/socket {
    # Peers send a message to the tracker every 15 minutes
    # Don't close the websocket before then
    proxy_read_timeout 15m; # default is 60s

    try_files /dev/null @api_websocket;
  }

  ##
  # Performance optimizations
  # For extra performance please refer to https://github.com/denji/nginx-tuning
  ##

  root /var/www/peertube/storage;

  # Enable compression for JS/CSS/HTML, for improved client load times.
  # It might be nice to compress JSON/XML as returned by the API, but
  # leaving that out to protect against potential BREACH attack.
  gzip              on;
  gzip_vary         on;
  gzip_types        # text/html is always compressed by HttpGzipModule
                    text/css
                    application/javascript
                    font/truetype
                    font/opentype
                    application/vnd.ms-fontobject
                    image/svg+xml;
  gzip_min_length   1000; # default is 20 bytes
  gzip_buffers      16 8k;
  gzip_comp_level   2; # default is 1

  client_body_timeout       30s; # default is 60
  client_header_timeout     10s; # default is 60
  send_timeout              10s; # default is 60
  keepalive_timeout         10s; # default is 75
  resolver_timeout          10s; # default is 30
  reset_timedout_connection on;
  proxy_ignore_client_abort on;

  tcp_nopush                on; # send headers in one piece
  tcp_nodelay               on; # don't buffer data sent, good for small data bursts in real time

  # If you have a small /var/lib partition, it could be interesting to store temp nginx uploads in a different place
  # See https://nginx.org/en/docs/http/ngx_http_core_module.html#client_body_temp_path
  #client_body_temp_path /var/www/peertube/storage/nginx/;

  # Bypass PeerTube for performance reasons. Optional.
  # Should be consistent with client-overrides assets list in /server/controllers/client.ts
  location ~ ^/client/(assets/images/(icons/icon-36x36\.png|icons/icon-48x48\.png|icons/icon-72x72\.png|icons/icon-96x96\.png|icons/icon-144x144\.png|icons/icon-192x192\.png|icons/icon-512x512\.png|logo\.svg|favicon\.png|default-playlist\.jpg|default-avatar-account\.png|default-avatar-video-channel\.png))$ {
    add_header Cache-Control "public, max-age=31536000, immutable"; # Cache 1 year

    root /var/www/peertube;

    try_files /storage/client-overrides/$1 /peertube-latest/client/dist/$1 @api;
  }

  # Bypass PeerTube for performance reasons. Optional.
  location ~ ^/client/(.*\.(js|css|png|svg|woff2|otf|ttf|woff|eot))$ {
    add_header Cache-Control "public, max-age=31536000, immutable"; # Cache 1 year

    alias /var/www/peertube/peertube-latest/client/dist/$1;
  }

  # Bypass PeerTube for performance reasons. Optional.
  location ~ ^/static/(thumbnails|avatars)/ {
    if ($request_method = 'OPTIONS') {
      add_header Access-Control-Allow-Origin  '*';
      add_header Access-Control-Allow-Methods 'GET, OPTIONS';
      add_header Access-Control-Allow-Headers 'Range,DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type';
      add_header Access-Control-Max-Age       1728000; # Preflight request can be cached 20 days
      add_header Content-Type                 'text/plain charset=UTF-8';
      add_header Content-Length               0;
      return 204;
    }

    add_header Access-Control-Allow-Origin    '*';
    add_header Access-Control-Allow-Methods   'GET, OPTIONS';
    add_header Access-Control-Allow-Headers   'Range,DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type';
    add_header Cache-Control                  "public, max-age=7200"; # Cache response 2 hours

    rewrite ^/static/(.*)$ /$1 break;

    try_files $uri @api;
  }

  # Bypass PeerTube for performance reasons. Optional.
  location ~ ^/static/(webseed|redundancy|streaming-playlists)/ {
    limit_rate_after            5M;

    # Clients usually have 4 simultaneous webseed connections, so the real limit is 3MB/s per client
    set $peertube_limit_rate    800k;

    # Increase rate limit in HLS mode, because we don't have multiple simultaneous connections
    if ($request_uri ~ -fragmented.mp4$) {
      set $peertube_limit_rate  5M;
    }

    # Use this line with nginx >= 1.17.0
    #limit_rate $peertube_limit_rate;
    # Or this line if your nginx < 1.17.0
    set $limit_rate $peertube_limit_rate;

    if ($request_method = 'OPTIONS') {
      add_header Access-Control-Allow-Origin  '*';
      add_header Access-Control-Allow-Methods 'GET, OPTIONS';
      add_header Access-Control-Allow-Headers 'Range,DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type';
      add_header Access-Control-Max-Age       1728000; # Preflight request can be cached 20 days
      add_header Content-Type                 'text/plain charset=UTF-8';
      add_header Content-Length               0;
      return 204;
    }

    if ($request_method = 'GET') {
      add_header Access-Control-Allow-Origin  '*';
      add_header Access-Control-Allow-Methods 'GET, OPTIONS';
      add_header Access-Control-Allow-Headers 'Range,DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type';

      # Don't spam access log file with byte range requests
      access_log off;
    }

    # Enabling the sendfile directive eliminates the step of copying the data into the buffer
    # and enables direct copying data from one file descriptor to another.
    sendfile on;
    sendfile_max_chunk 1M; # prevent one fast connection from entirely occupying the worker process. should be > 800k.
    aio threads;

    rewrite ^/static/webseed/(.*)$ /videos/$1 break;
    rewrite ^/static/(.*)$         /$1        break;

    try_files $uri @api;
  }
}
Chocobozzz commented 2 years ago

Try to replace location = /api/v1/videos/(upload|([^/]+/studio/edit))$ { by location ~ ^/api/v1/videos/(upload|([^/]+/studio/edit))$ {

Tr4sK commented 2 years ago

Did I make a typo ? :)

Tr4sK commented 2 years ago

I did, thx :1st_place_medal: