Chocobozzz / PeerTube

ActivityPub-federated video streaming platform using P2P directly in your web browser
https://joinpeertube.org/
GNU Affero General Public License v3.0
13.09k stars 1.51k forks source link

Admin log interface: filters for client/server logs #5485

Open JohnXLivingston opened 1 year ago

JohnXLivingston commented 1 year ago

Describe the problem to be solved

With recent Peertube version, it is possible to get client logs and store them on the server.

Yesterday, I was looking for error logs on the server, and they were hidden in the middle of a lot of client logs.

Describe the solution you would like

When reading logs on https://my_instance.tld/admin/system/logs, it would be very helpfull to have quick filters for:

kontrollanten commented 1 year ago

Hi! I'm wondering if all monitoring, etc should be moved out of PeerTube and instead promote usage of Grafana as visualization. Grafana is built for this kind of usage and has a lot of more sophisticated tools of analyzing.

It's nice that PeerTube has some kind of easy monitoring tools out of the box, but maybe we could change that to a docker-compose.yml that will setup Grafana, Prometheus, Loki and Tempo.

JohnXLivingston commented 1 year ago

Hi! I'm wondering if all monitoring, etc should be moved out of PeerTube and instead promote usage of Grafana as visualization. Grafana is built for this kind of usage and has a lot of more sophisticated tools of analyzing.

One does not prevent the other. In fact, there are already such possibilities:

It's nice that PeerTube has some kind of easy monitoring tools out of the box, but maybe we could change that to a docker-compose.yml that will setup Grafana, Prometheus, Loki and Tempo.

IMHO, the role of the Peertube documentation is not to document how to install these systems. It could only result in outdated documentation. Moreover, Docker is not the only way to setup Peertube.

kontrollanten commented 1 year ago

To clarify; my proposal is that PeerTube removes all logging visualization in the web client, and instead refers to Grafana.

Chocobozzz commented 1 year ago

I think we should keep a simple interface to view logs on PeerTube: it help to maintain the software and answer to questions/issues because some admins don't even know where PeerTube logs are on their system. Having this web interface simplifies pasting logs from admin etc.

JohnXLivingston commented 1 year ago

I totally agree with @Chocobozzz Moreover, it makes it simplier for admin to see log where there is an urgent problem, with their smartphones, when they have no access to other logging systems.