peertube-runner transcoding plugins

Chocobozzz / PeerTube

ActivityPub-federated video streaming platform using P2P directly in your web browser

https://joinpeertube.org/

GNU Affero General Public License v3.0

12.75k stars 1.46k forks source link

peertube-runner transcoding plugins #5858

Open Kepler-Br opened 1 year ago

Kepler-Br commented 1 year ago

Describe the problem to be solved

We have transcoding plugins on server side, but when I turn on remote runners, transcoding plugins are disabled. It would be nice to have peertube-runner side transcoding plugins

Describe the solution you would like

Document the way we can modify peertube-runner to have a custom ffmpeg command running;
Add plugin support;
Form ffmpeg command on the server side and then send it to a peertube-runner to be executed (maybe the best solution?)

Will be eternally grateful if you add support for two pass transcoding on remote runners

Thank you!

vid-bin commented 1 year ago

I haven't gotten around to testing the runners yet but this would be a showstopper for me. My instance heavily uses the transcoding profile debug plugin.

normen commented 11 months ago

..and GPU support! But I suppose the big problem is that the profiles might have to be per-runner as they all might have different hardware setups? So I guess the base CPU profile is chosen for the best compatibility here?

Edit: Looks like the runner is just executing whatever "ffmpeg" it can find first. So you can just replace that with a script that does what you want.

Kepler-Br commented 11 months ago

..and GPU support! But I suppose the big problem is that the profiles might have to be per-runner as they all might have different hardware setups? So I guess the base CPU profile is chosen for the best compatibility here?

Edit: Looks like the runner is just executing whatever "ffmpeg" it can find first. So you can just replace that with a script that does what you want.

You're right. Replacing original ffmpeg executable with your own script sounds much simpler than implementing your own runner. Too bad I haven't thought about that earlier

Hoerli1337 commented 4 months ago

The possibility of giving the Runner the profiles would be really good. So far it can only do x264. But I would really like to use AV1.

Is it currently possible to edit the codec in the runner itself?

Chocobozzz commented 4 months ago

Is it currently possible to edit the codec in the runner itself?

Sure, you can easily fork the runner or adapt ffmpeg command.