Chocobozzz / PeerTube

ActivityPub-federated video streaming platform using P2P directly in your web browser
https://joinpeertube.org/
GNU Affero General Public License v3.0
12.93k stars 1.48k forks source link

Add all missing config as Docker env #6591

Open kodxana opened 1 day ago

kodxana commented 1 day ago

Describe the current behavior

So I have updated my docker instalation to v6.3.0 to use new yt-dl proxy option though after upgrade I cant see option from web ui or in config files. Other UI elements from update like transcript shows fine.

Are there any docs on how to set proxy corectly?

Steps to reproduce

  1. docker compose down -v
  2. docker compose pull
  3. docker compose up -d
  4. No option to provide proxy

Describe the expected behavior

There it should be indication how to set proxy corectly.

Additional information

Chocobozzz commented 1 day ago

Hi,

Put a production.yaml in your docker-volume/config directory that contains key you want (like https://github.com/Chocobozzz/PeerTube/blob/develop/config/production.yaml.example#L835). So for example:

import:
  videos:
    http:
      proxies:
        - "https://username:password@example.com:8888"
kodxana commented 1 day ago

Do I need to put whole production.yaml or can be just that fragment. I already have local-production.json in that folder.

kodxana commented 1 day ago

Ok I think it works now but docker image is missing some deps for https proxy to work.

ERROR: To use an HTTPS proxy for this request, one of the following dependencies needs to be installed: requests, curl_cffi
Chocobozzz commented 1 day ago

Do I need to put whole production.yaml

No, only the key you need.

Ok I think it works now but docker image is missing some deps for https proxy to work.

Try to use a youtube-dl binary that contains these dependencies: https://github.com/Chocobozzz/PeerTube/blob/develop/config/production.yaml.example#L815

kodxana commented 1 day ago

Nice it works now after switched proxy to http all works fine and can import videos now :)

Chocobozzz commented 1 day ago

Reopening this issue because I changed its scope so we properly implement all PeerTube config as Docker env

I also added a note in the configuration file: https://github.com/Chocobozzz/PeerTube/commit/e03dfa6c82c2b954fa235ca8e86af601e293272d