Preview image file removed for Live when replay thumbnail updated - Githubissues

Chocobozzz / PeerTube

ActivityPub-federated video streaming platform using P2P directly in your web browser

https://joinpeertube.org/

GNU Affero General Public License v3.0

13.04k stars 1.5k forks source link

Preview image file removed for Live when replay thumbnail updated #6673

Open kntndrsn opened 6 days ago

kntndrsn commented 6 days ago

Describe the current behavior

When a replay of a permanent live is saved, it references the preview image of the live. If you change the thumbnail on the replay, it appears to remove the preview image file of the live.

Example Live: https://video.bbccolumbus.com/w/wT9mi5VQ3N2RHTrQ87TjqN

Steps to reproduce

Setup live with a custom thumbnail image.
Initiate live and finish to create replay.
Change thumbnail on replay.
Original live preview image file will be gone. (thumbnail image file will still be there)

Describe the expected behavior

Previous to 6.3, replays would generate their own thumbnail and preview images. However, at a minimum, it shouldn't delete the preview image file of the original live when you change the thumbnail of a replay.

Additional information

PeerTube instance:
- URL:
- Version: 6.3.2
- NodeJS version: 21.7.3
- Ffmpeg version: 4.4.2-0ubuntu0.22.04.1
Browser name, version and platforms on which you could reproduce the bug:
Link to browser console log if relevant:
Link to server log if relevant (journalctl or /var/www/peertube/storage/logs/):

stevespaw commented 2 days ago

We have the same unexpected behavior.