search

Chocobozzz / PeerTube

ActivityPub-federated video streaming platform using P2P directly in your web browser
https://joinpeertube.org/
GNU Affero General Public License v3.0
13.1k stars 1.51k forks source link

Translate page titles too #793

Closed bristow closed 4 years ago

bristow commented 6 years ago

In the menu, 'More' is also not translated.

Thanks :)

Chocobozzz commented 6 years ago

Thanks, for the "More" it should be fixed: https://github.com/Chocobozzz/PeerTube/commit/b63e428e8bf1ed1457ab1888350809bd78ce4d2f

KRtekTM commented 6 years ago

I translated the PeerTube to the Czech language which is now visible on the instance mentioned above. Now I see few issues:

https://peertube2.cpy.re/about/peertube Everything is translated except of string "How does PeerTube compare with YouTube?" In the Zanata, the source string was "How does PeerTube compares to YouTube?" which was translated to CZ.

On the same page, the string "About PeerTube" is correctly translated but the page title (in html tag) is still in english.</p> <p>On the page with video player, there is notification bar with untranslated string "The sharing system used by this video implies that some technical information about your system (such as a public IP address) can be sent to other peers." which source is Zanata was "The sharing system used by this video implies that some technical information about your system (such as a public IP address) can be accessed publicly."</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/KRtekTM"><img src="https://avatars.githubusercontent.com/u/6234196?v=4" />KRtekTM</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>Also I wondered that in Zanata, there is no source for 3 characters shortcut for month of May (all other months are included) and May has only full version. E.g. in Czech language, the month of May is called "květen" and the known shortcut for this month is "kvě", which I can't add now. (yes, Czech language is weird and has completely different names for months than other languages. On the other side, the Slovak language which is understandable by czech people has months named as Január, Február etc., so maybe the "May shortcut issue" is valid just for the CZ :D)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/KRtekTM"><img src="https://avatars.githubusercontent.com/u/6234196?v=4" />KRtekTM</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>In addition I fixed two strings in Czech language, please can you again merge it to github so I can acquire the latest version? (I know it's out of scope of this task but I don't want to create new ticket on it). BIG THANKS</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/SerCom-KC"><img src="https://avatars.githubusercontent.com/u/15853348?v=4" />SerCom-KC</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>More untranslatable strings: <a href="https://github.com/Chocobozzz/PeerTube/blob/1cfa8d6809d941c703e12ef30a5161d1901b1874/client/src/app/videos/%2Bvideo-edit/shared/video-edit.component.html#L158">https://github.com/Chocobozzz/PeerTube/blob/1cfa8d6809d941c703e12ef30a5161d1901b1874/client/src/app/videos/%2Bvideo-edit/shared/video-edit.component.html#L158</a> <a href="https://github.com/Chocobozzz/PeerTube/blob/1cfa8d6809d941c703e12ef30a5161d1901b1874/client/src/app/videos/%2Bvideo-edit/shared/video-edit.component.html#L166">https://github.com/Chocobozzz/PeerTube/blob/1cfa8d6809d941c703e12ef30a5161d1901b1874/client/src/app/videos/%2Bvideo-edit/shared/video-edit.component.html#L166</a> <a href="https://github.com/Chocobozzz/PeerTube/blob/1cfa8d6809d941c703e12ef30a5161d1901b1874/client/src/app/videos/%2Bvideo-edit/shared/video-edit.component.html#L174">https://github.com/Chocobozzz/PeerTube/blob/1cfa8d6809d941c703e12ef30a5161d1901b1874/client/src/app/videos/%2Bvideo-edit/shared/video-edit.component.html#L174</a> <a href="https://github.com/Chocobozzz/PeerTube/blob/1cfa8d6809d941c703e12ef30a5161d1901b1874/client/src/app/videos/%2Bvideo-edit/shared/video-edit.component.html#L182">https://github.com/Chocobozzz/PeerTube/blob/1cfa8d6809d941c703e12ef30a5161d1901b1874/client/src/app/videos/%2Bvideo-edit/shared/video-edit.component.html#L182</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/SerCom-KC"><img src="https://avatars.githubusercontent.com/u/15853348?v=4" />SerCom-KC</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>Also, regarding of date formatting, can we specify the actual format for each language instead of forcing everyone to use, say, <code>MM YYYY</code> (which I believe is the current behavior in the date selector)? e.g. In Chinese we prefer <code>YYYY年MM月</code>。</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/rigelk"><img src="https://avatars.githubusercontent.com/u/6329880?v=4" />rigelk</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>@SerCom-KC I added the string to translate in cc3d1dce. Thanks for spotting them!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/SerCom-KC"><img src="https://avatars.githubusercontent.com/u/15853348?v=4" />SerCom-KC</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>Even more untranslatable strings (sorry but if you prefer a new issue for this let me know): <a href="https://github.com/Chocobozzz/PeerTube/blob/923406990334d133a49a283629322d1bbb521ecc/client/src/app/%2Badmin/config/edit-custom-config/edit-custom-config.component.ts#L19">https://github.com/Chocobozzz/PeerTube/blob/923406990334d133a49a283629322d1bbb521ecc/client/src/app/%2Badmin/config/edit-custom-config/edit-custom-config.component.ts#L19</a> <a href="https://github.com/Chocobozzz/PeerTube/blob/923406990334d133a49a283629322d1bbb521ecc/client/src/app/%2Badmin/config/edit-custom-config/edit-custom-config.component.ts#L29">https://github.com/Chocobozzz/PeerTube/blob/923406990334d133a49a283629322d1bbb521ecc/client/src/app/%2Badmin/config/edit-custom-config/edit-custom-config.component.ts#L29</a> <a href="https://github.com/Chocobozzz/PeerTube/blob/923406990334d133a49a283629322d1bbb521ecc/client/src/app/%2Badmin/config/edit-custom-config/edit-custom-config.component.ts#L43">https://github.com/Chocobozzz/PeerTube/blob/923406990334d133a49a283629322d1bbb521ecc/client/src/app/%2Badmin/config/edit-custom-config/edit-custom-config.component.ts#L43</a></p> <p>Also @rigelk Zanata doesn't seem to be updated?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/rigelk"><img src="https://avatars.githubusercontent.com/u/6329880?v=4" />rigelk</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>@SerCom-KC it's fine ; Zanata is updated manually by @Chocobozzz so it might take some days before we do the operation.</p> <p>Btw @Chocobozzz I don't see an elegant way of translating these string, since they are in static attributes.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Chocobozzz"><img src="https://avatars.githubusercontent.com/u/5180488?v=4" />Chocobozzz</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>@SerCom-KC Thanks, I fixed it in <a href="https://github.com/Chocobozzz/PeerTube/commit/3827c3b3488845f4235714e92eea439423df2909">https://github.com/Chocobozzz/PeerTube/commit/3827c3b3488845f4235714e92eea439423df2909</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/SerCom-KC"><img src="https://avatars.githubusercontent.com/u/15853348?v=4" />SerCom-KC</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>@Chocobozzz Thank you! Here's another bunch: every <code>.send</code> occurrence in <a href="https://github.com/Chocobozzz/PeerTube/blob/ad76628b17ff8f25d3402d6d669b274116bbf76c/server/middlewares/validators/users.ts">https://github.com/Chocobozzz/PeerTube/blob/ad76628b17ff8f25d3402d6d669b274116bbf76c/server/middlewares/validators/users.ts</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Chocobozzz"><img src="https://avatars.githubusercontent.com/u/5180488?v=4" />Chocobozzz</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>@SerCom-KC I created a separate issue: <a href="https://github.com/Chocobozzz/PeerTube/issues/1122">https://github.com/Chocobozzz/PeerTube/issues/1122</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Folaht"><img src="https://avatars.githubusercontent.com/u/9342090?v=4" />Folaht</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>Can "Jobs" in the admin menu be changed into something more French? And also can the info piece of "Instance sur la liste blanche de Twitter" be in French as well?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/AlphaShadows77"><img src="https://avatars.githubusercontent.com/u/40860088?v=4" />AlphaShadows77</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>Some titles are still missing in Zanata (With example from <a href="https://peertube.iriseden.eu">iriseden</a>)</p> <ul> <li>Discover videos => <a href="https://peertube.iriseden.eu/videos/overview">https://peertube.iriseden.eu/videos/overview</a></li> <li>Trending videos => <a href="https://peertube.iriseden.eu/videos/trending">https://peertube.iriseden.eu/videos/trending</a></li> <li>Recently added videos => <a href="https://peertube.iriseden.eu/videos/recently-added">https://peertube.iriseden.eu/videos/recently-added</a></li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Chocobozzz"><img src="https://avatars.githubusercontent.com/u/5180488?v=4" />Chocobozzz</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Implemented in <a href="https://github.com/Chocobozzz/PeerTube/commit/f29f487ef8892453a481628a6a3cff802dc89213">https://github.com/Chocobozzz/PeerTube/commit/f29f487ef8892453a481628a6a3cff802dc89213</a> :tada: </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/bristow"><img src="https://avatars.githubusercontent.com/u/1156507?v=4" />bristow</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>We need to translate now, it's done in french : <a href="https://weblate.framasoft.org/projects/peertube/">https://weblate.framasoft.org/projects/peertube/</a></p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>