search

Chocohead / Fabric-ASM

Just what Asie never wanted
Mozilla Public License 2.0
158 stars 19 forks source link

Manningham Mills (Farbic-ASM) showing up in Mod Menu #12

Open Eiion opened 2 years ago

Eiion commented 2 years ago

With Minecraft v1.18 Manningham Mills (which apparently is Farbic-ASM if I'm informed correctly) shows up in the Mod Menu causing confusion what this mod (i.e. Manningham Mills) is supposed to be when nothing like it was downloaded and put into the mods folder by the user.

Should this be a hidden mod or at least named differently so people can make a connection to it being part of OptiFabric?

(https://github.com/FabricMC/fabric/issues/1876#issue-1069287439)

Daomephsta commented 2 years ago

It's not part of OptiFabric. OptiFabric bundles Fabric-ASM, but it's an independent project. Also if you aren't already aware, there are alternatives to Optifine/OptiFabric.

Eiion commented 2 years ago

That's what multiple people have told me on the Optifine Discord. Also, I wasn't aware. I'll have a look at it - thanks. (The potential issue I am seeing with such alternatives is incompatibility with e.g. BSL shaders and such.)

Anyways, that doesn't solve the issue. I've never downloaded Manningham Mill, I've never put it in the mods folder - still it's there. Apparently (as I've been told) because it's part of Optifabric. It didn't show up in the versions for 1.16 nor for those of 1.17 - but does now in 1.18.

jackassmc commented 2 years ago

This is caused by the deprecation of the old syntax of marking mods as libraries ("modmenu:api" : true).

To mark a mod as a library in ModMenu 3+ the new syntax is:

"custom": {
    "modmenu": {
        "badges": [ "library" ]
    }
}
AnandBhasme commented 2 years ago

So what does Manningham Mills do? I have same problem

Daomephsta commented 2 years ago

So what does Manningham Mills do? I have same problem

It's a library used by mods to alter vanilla. You have it because a mod you've installed includes it.