Settings menu

[suleyman222]

Added a settings menu on the main menu and on the pause menu, which can manage some audio (music/sound effect volume) and video settings (full screen, resolution, enabling fisheye lens effect). Closes #80, #82, #83

Changes

• Separated music and sound effects volume.
  • Added an AudioMixer to the project (Assets/Audio/MainMixer)
  • Put an additional AudioSource on the GameManager The two AudioSource manage different AudioMixerGroups.
• Created a SettingsCanvas prefab with sliders for music volume, toggle boxes for enabling fullscreen and enabling fisheye lens effect, dropdown menu for selecting resolution (see pic below). The topmost GameObject of the prefab has the SettingsMenu script on itself. The rest of the components (actual UI components) are disabled by default. The topmost component is enabled by default to load the settings on startup.
• Added the SettingsCanvas prefab and a "Settings" button to the MainMenu Scene. The button enables/disables the UI components in the SettingsCanvas.
• Added a new prefab PauseWithSettings and replaced the PauseMenu in the EssentialsLoader with this new prefab. PauseWithSettings consists of the PauseCanvas prefab and SettingsCanvas prefab. It was created to easily couple the PauseCanvas and SettingsCanvas.

Future recommendations

• Perhaps change the visuals of the sliders, toggle boxes and dropdown menu.

[howchen217]

Review

Quality work! I am just not entirely sure if it is necessary to have the apply button there, instead apply the changes immediately. Minecraft for example doesn't have an apply button. Most settings menus do have the reset to default button instead.

• [ ] Maybe a reset to the default button, but not have the apply button to make changes more responsive?
• [ ] The fisheye is not disabled by default currently? Actually, fisheye option is ticked, but there is no fisheye?
• [ ] Esc button does not work to return to the previous page when in settings menu?
• [ ] Fisheye does not automatically turn on when story canvas is playing yet?
• [ ] Resolutions does not yet seem to work?

[PavlosMak]

Great work, both in terms of code quality and of the features implemented. Some notes I had (some overlap with Hao's above comment)

• Clicking Apply does not close the menu (not sure if it is intentional)
• Cannot check resolutions (I think this is because I tested it in the editor)
• It would be nice if pressing esc would close the menu

Great work once again (and thanks for the detailed PR)

[suleyman222]

Thanks for the great feedback guys. There was a small bug that broke the resolution dropdown menu, which should be fixed now. I also completely forgot to turn fisheye off by default, so I quickly changed that too. Some more changes that I'll add in the upcoming commits are:

• Closing the settings with the Escape key (this will save the settings and close the settings menu).
• Remove the Apply button.
• The Back button will save the settings, close the settings menu and bring the player back to the pause menu.
• Add a Reset button (to reset the settings to the default values).
• Turn on the fisheye lens effect during the story canvas.