ChoiceTheorem / ChoiceTheorem-s-overhauled-village

Enhances and creates new villages and pillager outposts, that perfectly fit into your Minecraft world.
https://modrinth.com/mod/ct-overhaul-village
Other
55 stars 11 forks source link

[BUG] Some generation issues with windmills of "Create: Structures" #187

Closed Josuburga closed 3 months ago

Josuburga commented 3 months ago

Describe the bug In some of the villages the windmills added by the Create: Structures are generated without walls. For example I found this issue in a mangrove swamp village and in a snowy one (I don't know the type of that one exactly because I found it while exploring, sorry)

To Reproduce Steps to reproduce the behaviour:

  1. Install CTOV and Create: Structures (there is in-built compatibility)
  2. Go to a Mangrove Swamp Village or some other village to find this issue (it's just in some of them)

Expected behaviour To all of these windmills to generate correctly, or that in those specific villages to not generate due to this bug

Screenshots 2024-08-05_12 02 08 2024-08-05_12 06 33

Minecraft Version 1.20.1

CTOV Version 3.4.6

Do you install Lithostitched?(1.20+) Yes

ChoiceTheorem commented 3 months ago

Some of them doesn't have walls. Screenshot some footage for me

On Mon, Aug 5, 2024, 17:34 Josuburga @.***> wrote:

Assigned #187 https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/issues/187 to @ChoiceTheorem https://github.com/ChoiceTheorem.

— Reply to this email directly, view it on GitHub https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/issues/187#event-13762175640, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCFLZPKN5WKY55K4UOGOWTZP5IMVAVCNFSM6AAAAABMAAUKHOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTG43DEMJXGU3DIMA . You are receiving this because you were assigned.Message ID: <ChoiceTheorem/ChoiceTheorem-s-overhauled-village/issue/187/issue_event/13762175640 @github.com>

Josuburga commented 3 months ago

Ok so after searching I found out that 2 villages have this issue: the "Savanna_na" (first 2 screenshots) and "Swamp" (last 2 screenshots). Also, in the last screenshot I found that the wood used for the Bountiful generation part is different from the one of the village.

image image image image

The other villages I found (even "Savanna" and "Swamp Fortified") had it okay.

And other thing. How common is for one of these windmills to generate in a village? Because in some of them I found like 3-4 of them really close to each other, which I found a little bit strange.

ChoiceTheorem commented 3 months ago
Josuburga commented 3 months ago
  • Those windmills are designed without walls, as weird as it is.

Then wouldn't it be better to not have windmills in those villages? Because it's really strange to find those structures without walls at all. In the other villages they generate correctly, so it's not that they wouldn't generate anywhere, right?

ChoiceTheorem commented 3 months ago

I might revise the build to have walls if I have a way to keep them in line with the rest of the village. To me, it is generated correctly and that's what's matter here.

Josuburga commented 3 months ago

Ok, and one last thing I want to know. This is completely sepparated from the bug I told here, just my curiosity. Is it normal that sometimes the villages are generated in really "vertical" places? (places like a big mountain for example). There are situations where some houses end up "floating", inside the mountain or in a cave that's just below the village, which is a little bit strange.

ChoiceTheorem commented 3 months ago

A normal but will try to avoid situation