ChoiceTheorem / ChoiceTheorem-s-overhauled-village

Enhances and creates new villages and pillager outposts, that perfectly fit into your Minecraft world.
https://modrinth.com/mod/ct-overhaul-village
Other
55 stars 11 forks source link

[BUG] Domestication Innovation Pet Shops have no Animals #194

Closed SdeSpencer closed 2 months ago

SdeSpencer commented 3 months ago

Describe the bug Pet Shops (with Domestication Innovation) have no animals

To Reproduce Steps to reproduce the behaviour:

  1. Have both CTOV and Domestication Innovation installed
  2. Go to any pet shop in a CTOV village
  3. See there are no animals

Expected behaviour There to be animals in the pet shop, lining up with pet shops as they exist in standard Domestication Innovation pet shops

Minecraft Version 1.20.1

CTOV Version 3.4.5

Do you install Lithostitched?(1.20+) Yes

Log latest.log (I doubt this will be useful, but for completeness)

ChoiceTheorem commented 3 months ago

I forgot to put a disclaimer that this will happen, anyway I'm try to replicate Alex's way of placing pets

kirballs commented 2 months ago

This problem still persists to me in version 3.4.7

ChoiceTheorem commented 2 months ago

Really? Does every village pet shop is empty? or only some? Only new pet shop will have animals

kirballs commented 2 months ago

In one village with two pet shops i found one with a wolf and one empty, another village had both empty, and they were newly generated

ChoiceTheorem commented 2 months ago

So some spawn huh? Okay

On Wed, Sep 11, 2024, 01:03 kirballs @.***> wrote:

In one village with two pet shops i found one with a wolf and one empty, another village had both empty, and they were newly generated

— Reply to this email directly, view it on GitHub https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/issues/194#issuecomment-2341636126, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCFLZLEVOF5PQGXZUKHZKDZV4X5LAVCNFSM6AAAAABMU4EMK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBRGYZTMMJSGY . You are receiving this because you modified the open/close state.Message ID: <ChoiceTheorem/ChoiceTheorem-s-overhauled-village/issues/194/2341636126@ github.com>

kirballs commented 2 months ago

I found a large desert village with like 10 shops all empty...

ChoiceTheorem commented 2 months ago

It largely depends on where in the village it is located. A more central location is more likely to have pets

On Thu, 12 Sep 2567 BE at 04:47, kirballs @.***> wrote:

I found a large desert village with like 10 shops all empty...

— Reply to this email directly, view it on GitHub https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/issues/194#issuecomment-2344760292, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCFLZKUN6GQPRJRY6URLTLZWC26JAVCNFSM6AAAAABMU4EMK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUG43DAMRZGI . You are receiving this because you modified the open/close state.Message ID: <ChoiceTheorem/ChoiceTheorem-s-overhauled-village/issues/194/2344760292@ github.com>

kirballs commented 2 months ago

Aren't all pet shops supposed to have pets by definition?

ChoiceTheorem commented 2 months ago

What I said is the technical limitation of spawning pets in the shops. Minecraft structure spawns by sizes.

On Thu, 12 Sept 2024 at 23:59, kirballs @.***> wrote:

Aren't all pet shops supposed to have pets by definition?

— Reply to this email directly, view it on GitHub https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/issues/194#issuecomment-2346806936, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCFLZNBPB5VHC56EMTIAB3ZWHB7RAVCNFSM6AAAAABMU4EMK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBWHAYDMOJTGY . You are receiving this because you modified the open/close state.Message ID: <ChoiceTheorem/ChoiceTheorem-s-overhauled-village/issues/194/2346806936@ github.com>

kirballs commented 1 month ago

is this bug gonna be revised or are you keeping it like this, cause repurposed structures villages has no problems and even put alex mobs in shops

ChoiceTheorem commented 1 month ago

I may redo it a bit more