Choices-js / Choices

A vanilla JS customisable select box/text input plugin ⚡️
https://choices-js.github.io/Choices/
MIT License
6.17k stars 607 forks source link

[BUGFIX] Fix support for non-Latin characters #1072

Closed ousmorez closed 1 year ago

ousmorez commented 1 year ago

Description

I've added some more characters to the dropdown opener in the regex, so that the dropdown opens when the following keys are pressed on the keyboard: MacTigr-thumb-top Because if those characters are available to type, they can open the drop-down menu after pressing. Also correct first character when trying to type numbers or non-English.

it solves following bug:

https://github.com/Choices-js/Choices/issues/1068

Types of changes

Checklist

ousmorez commented 1 year ago

I checked the error in the pipeline and found that the problem is solved if the following packages are installed:

  "pixelmatch": "^5.3.0",
  "puppeteer": "^19.2.2",

We need to add these packages to package.json. This has nothing to do with my changes, should I add these packages? @mtriff

ousmorez commented 1 year ago

I can't resolve the failed checks, can you please help me? @mtriff

mtriff commented 1 year ago

Thanks so much for the contribution @ousmorez!