fix/multiple classnames

gaetan-hexadog commented 1 year ago

Description

In some cases, we want to be able to pass multiple class names like so 'list first second'. However, this is making an error because classList.add doesn't support space.

This PR attempts to implement allowing multi-class configs for all elements across the board by allowing to pass an array of strings for classNames.

It takes into account feedbacks from PR#907 submitted by @mikebronner

Fix #832 #889

Types of changes

[ ] Chore (tooling change or documentation change)
[ ] Refactor (non-breaking change which maintains existing functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] My code follows the code style of this project.
[ ] I have added new tests for the bug I fixed/the new feature I added.
[x] I have modified existing tests for the bug I fixed/the new feature I added.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

mtriff commented 1 year ago

Thanks for this! Can you merge the latest version of master into this branch? After that I will review it.

gaetan-hexadog commented 1 year ago

Thanks for this! Can you merge the latest version of master into this branch? After that I will review it.

Done ;-)

ezitisitis commented 1 year ago

I have a feeling that when @mtriff will get back to this, @gaetan-hexadog will need to merge latest master once again 🤣

gaetan-hexadog commented 1 year ago

@mtriff let me know when you'll be able to merge this PR so I can merge the latest version of master before (don't want to do it if you're not going to merge it quickly) ;-)

btmluiz commented 1 year ago

Hey, does anyone know when this PR will be merged?

ammaraslam10 commented 12 months ago

+1

KarelBrijs commented 11 months ago

+1

J2-Tech commented 9 months ago

+1

otherprod commented 8 months ago

Please come back, we need the multiple class override, thx

MeetJF commented 8 months ago

We need this

liamseys commented 6 months ago

@gaetan-hexadog Whats with this?

gaetan-hexadog commented 6 months ago

@gaetan-hexadog Whats with this?

No news from the repo'd owner. I won't work on it for the third time if I don't have the insurance it will be merged quickly. Feel free to use my PR if you want.

ammaraslam10 commented 5 months ago

There should be a protocol for when the owner stops responding for more than a year...

Xon commented 1 month ago

Thanks! Implemented as part of #1166

Choices-js / Choices