[BUGFIX] Fix selectbox issue

ousmorez commented 1 year ago

Description

It's going to solve following bug: https://github.com/Choices-js/Choices/issues/1080

Screenshots (if appropriate)

Types of changes

Add this condition to the if statement to open a dropdown. This means only type characters less than 2 in length inside the select box.

 event.key.length === 1

[x] Chore (tooling change or documentation change)
[ ] Refactor (non-breaking change which maintains existing functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] My code follows the code style of this project.
[ ] I have added new tests for the bug I fixed/the new feature I added.
[ ] I have modified existing tests for the bug I fixed/the new feature I added.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

ousmorez commented 1 year ago

@mtriff I have the same problem with checks as the old pull request, could you help me solve it please?

mtriff commented 1 year ago

That's unfortunate, we should have caught that in testing. Can you add an end-to-end test that fails when this happens?

Also, it looks like something odd is going on with this MR. I'm not seeing any new changes in the diff, only things from the last MR that have already been merged. Can you create a new fork off master and a new MR with the fix?

ousmorez commented 1 year ago

That's unfortunate, we should have caught that in testing. Can you add an end-to-end test that fails when this happens?

Also, it looks like something odd is going on with this MR. I'm not seeing any new changes in the diff, only things from the last MR that have already been merged. Can you create a new fork off master and a new MR with the fix?

Ok, i will do the changes. thx for answering.

Choices-js / Choices