[BUGFIX] Fix selectbox issue #1081 - Githubissues

Choices-js / Choices

A vanilla JS customisable select box/text input plugin ⚡️

https://choices-js.github.io/Choices/

MIT License

6.06k stars 598 forks source link

[BUGFIX] Fix selectbox issue #1081 #1093

Open ousmorez opened 1 year ago

ousmorez commented 1 year ago

resolve #1080

Description

It's going to solve following bug: https://github.com/Choices-js/Choices/issues/1080

Screenshots (if appropriate)

Types of changes

Add this condition to the if statement to open a dropdown. This means only type characters less than 2 in length inside the select box.

event.key.length === 1

[x] Chore (tooling change or documentation change)
[ ] Refactor (non-breaking change which maintains existing functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] My code follows the code style of this project.
[ ] I have added new tests for the bug I fixed/the new feature I added.
[ ] I have modified existing tests for the bug I fixed/the new feature I added.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

ousmorez commented 1 year ago

@mtriff This time I didn't even clone the project on my computer, I just edited the considered line on github! I don't know what the problem is and how to write a end-to-end test for it.

The failed review is related to puppeteer, I just know that I can fix this problem on my computer by installing puppeteer, not sure if it will work here.

Can you help me?