Fix mixed optgroups - Githubissues

Choices-js / Choices

A vanilla JS customisable select box/text input plugin ⚡️

https://choices-js.github.io/Choices/

MIT License

6.06k stars 598 forks source link

Fix mixed optgroups #1110

Open voidus opened 1 year ago

voidus commented 1 year ago

Description

Fixes #615 basically.

It includes a working cypress test. I did not add unit tests, but I'd be happy to do so if you are planning to merge this.

Screenshots (if appropriate)

choices

Types of changes

[ ] Chore (tooling change or documentation change)
[x] Refactor (non-breaking change which maintains existing functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

I'd call it a bug (see #615 ) but some might call it a new feature? Also minor refactorings.

Checklist

[x] My code follows the code style of this project.
[x] I have added new tests for the bug I fixed/the new feature I added.
[ ] I have modified existing tests for the bug I fixed/the new feature I added.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

I think it's worth a mention in the changelog though.

voidus commented 3 months ago

Wow I forgot about this PR.... anyone we could ping to move this forward?