Fixes an issue where passing in customProperties would render invalidly encoded object - Githubissues

Choices-js / Choices

A vanilla JS customisable select box/text input plugin ⚡️

https://choices-js.github.io/Choices/

MIT License

6.16k stars 607 forks source link

Fixes an issue where passing in customProperties would render invalidly encoded object #1154

Closed sdglhm closed 1 month ago

sdglhm commented 4 months ago

Description

This fixes an issue where when passing in customProperties to a Choice would lead to render [object Object] instead of properly rendering JSON structure.

Types of changes

[ ] Chore (tooling change or documentation change)
[ ] Refactor (non-breaking change which maintains existing functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] My code follows the code style of this project.
[x] I have added new tests for the bug I fixed/the new feature I added.
[ ] I have modified existing tests for the bug I fixed/the new feature I added.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Xon commented 1 month ago

Thanks, I've implemented a more comprehensive fix as part of #1166