search

ChoicescriptIDE / main

33 stars 6 forks source link

Renderer crashes / Failure to catch exceptions #103

Closed CareyJWilliams closed 4 years ago

CareyJWilliams commented 4 years ago

Bad JavaScript in CSIDE seems to be causing NWJS' Renderer process (and thus the app) to crash instantly (rather than throwing an error, or just halting as expected).

For e.g, running the following in the DevTools console:

var https = require('https');      
var request = https.get("https://fake.fake.com", function(response) {
        console.log(response);
});

Will trigger the crash, as will referencing undefined objects/members in modules.

Screenshot 2020-10-11 at 22 59 05

Note that this reproducer doesn't seem to work on a clean slate index.html. So there may be something odd going on with a dependency or two.

CareyJWilliams commented 4 years ago

https://github.com/nwjs/nw.js/issues/7343 might be related?

CareyJWilliams commented 4 years ago

This happens on Windows too. Looks like process.on("uncaughtException" isn't triggering.